You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/01 22:11:59 UTC

[GitHub] merlimat commented on a change in pull request #1168: Proxy roles enforcement

merlimat commented on a change in pull request #1168: Proxy roles enforcement
URL: https://github.com/apache/incubator-pulsar/pull/1168#discussion_r165504070
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
 ##########
 @@ -196,6 +202,16 @@ protected void handleLookup(CommandLookupTopic lookup) {
         if (lookupSemaphore.tryAcquire()) {
             final String originalPrincipal = lookup.hasOriginalPrincipal() ? lookup.getOriginalPrincipal()
                     : this.originalPrincipal;
+            if (service.isAuthorizationEnabled() && proxyRoles.contains(authRole)) {
 
 Review comment:
   We should have the 3 similar blocks of code in a single method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services