[jira] [Resolved] (GEODE-6421) CI failure: org.apache.geode.distributed.LocatorDUnitTest.testStartTwoLocators failed with AssertionError

["Bruce Schuchardt (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Schuchardt resolved GEODE-6421.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.9.0

A lot of race conditions in the code exercised by this test were fixed on 2/19 with this commit:

commit 7661eca53df6fa5c71ec21dc3de35eba5cb3e202
Author: Bruce Schuchardt <bs...@pivotal.io>
Date: Tue Feb 19 12:58:57 2019 -0800

GEODE-6369 Cache-creation failure after a successful auto-reconnect causes subsequent NPE
 
 If an error occurs while rebuilding the cache on auto-reconnect & we can't
 continue we should throw an exception to any thread waiting for the
 reconnect to complete.
 
 If we're unable to contact the cluster configuration service we do not
 terminate auto-reconnect attempts.
 
 New members are now only allowed to join after view preparation has
 completed. This will reduce the number of "surprise members" and also
 ensures that any old member IDs have been removed from the view.
 
 We now only attempt to use findCoordinatorFromView multiple times if the
 view actually changes. Instead we contact locators again to see if
 there are new registrants.
 
 fixing the above exposed other problems in auto-reconnect:
 
 * messages were being thrown away by the location service quorum checker
 during auto-reconnect. some of these were "join" messages that needed
 to be delivered to the new membership service
 
 * registrants weren't being removed from the recovered membership view
 in the locator. This confused restarting nodes because the recovered
 membership view has stale info in it that they don't want to use
 
 * locator services restart were hanging due to profile interchange being
 done under synchronization

> CI failure: org.apache.geode.distributed.LocatorDUnitTest.testStartTwoLocators failed with AssertionError
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-6421
>                 URL: https://issues.apache.org/jira/browse/GEODE-6421
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Lynn Gallinat
>            Priority: Major
>             Fix For: 1.9.0
>
>
> org.apache.geode.distributed.LocatorDUnitTest > testStartTwoLocators FAILED
>     org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.test.dunit.NamedRunnable.run in VM 2 running on Host f44e8e23cdaf with 6 VMs
>         at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:579)
>         at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
>         at org.apache.geode.distributed.LocatorDUnitTest.startVerifyAndStopLocator(LocatorDUnitTest.java:1799)
>         at org.apache.geode.distributed.LocatorDUnitTest.testStartTwoLocators(LocatorDUnitTest.java:317)
>         Caused by:
>         java.lang.AssertionError: expected:<2> but was:<1>
>             at org.junit.Assert.fail(Assert.java:88)
>             at org.junit.Assert.failNotEquals(Assert.java:834)
>             at org.junit.Assert.assertEquals(Assert.java:645)
>             at org.junit.Assert.assertEquals(Assert.java:631)
>             at org.apache.geode.distributed.LocatorDUnitTest.expectSystemToContainThisManyMembers(LocatorDUnitTest.java:139)
>             at org.apache.geode.distributed.LocatorDUnitTest.lambda$startVerifyAndStopLocator$2ba733bc$1(LocatorDUnitTest.java:1800)
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/405



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)