[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29979: Avoid considering EmptyOperator in mini scheduler

["ephraimbuddy (via GitHub)" <gi...@apache.org>]

ephraimbuddy commented on code in PR #29979:
URL: https://github.com/apache/airflow/pull/29979#discussion_r1129725652


##########
airflow/models/taskinstance.py:
##########
@@ -2651,7 +2651,11 @@ def schedule_downstream_tasks(self, session=None):
                 task_id for task_id in partial_dag.task_ids if task_id not in task.downstream_task_ids
             }
 
-            schedulable_tis = [ti for ti in info.schedulable_tis if ti.task_id not in skippable_task_ids]
+            schedulable_tis = [
+                ti
+                for ti in info.schedulable_tis
+                if ti.task_id not in skippable_task_ids and not ti.task.inherits_from_empty_operator
+            ]

Review Comment:
   I have some doubts; `dagrun.schedule_tis` marks empty operators as successful when called by the scheduler, how does it still get to this point?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org