[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

[GitBox <gi...@apache.org>]

vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r534118681



##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##########
@@ -72,11 +73,20 @@ public int epoch() {
         return voterReplicaStates.keySet().stream().filter(id -> id != localId).collect(Collectors.toSet());
     }
 
+    public Set<Integer> endorsingVoters() {

Review comment:
       Yeah that makes sense. As you explained, endorsing are those voters who have acknowledged the BeginQuorumEpoch request from the leader, so eventually if the leader is accepted, this set will be all the voters who voted. 
   Regarding endorsing v/s acknowledged, can we also add what has been acknowledged? Like, `endoresedQuorumEpoch` or `endorsedLeaderCandidacy` or something like this. Just adding context, might clear the confusion. WDYT @hachikuji , @jsancio 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org