[GitHub] [doris] jackwener commented on a diff in pull request #13601: [Feature](Nereids) Support join hint.

[GitBox <gi...@apache.org>]

jackwener commented on code in PR #13601:
URL: https://github.com/apache/doris/pull/13601#discussion_r1003391337


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -851,10 +855,23 @@ private LogicalPlan withJoinRelations(LogicalPlan input, RelationContext ctx) {
                 condition = Optional.ofNullable(getExpression(joinCriteria.booleanExpression()));
             }
 
+            JoinHint joinHint = Optional.ofNullable(join.joinHint()).map(hintCtx -> {
+                String hint = typedVisit(join.joinHint());
+                if (JoinHint.JoinHintType.SHUFFLE.toString().equalsIgnoreCase(hint)) {
+                    return JoinHint.SHUFFLE_RIGHT;
+                } else if (JoinHint.JoinHintType.BROADCAST.toString().equalsIgnoreCase(hint)) {
+                    return JoinHint.BROADCAST_RIGHT;
+                } else {
+                    throw new ParseException("Invalid join hint: " + hint, hintCtx);
+                }

Review Comment:
   we can add them into a function like `public static JoinHint of(String name)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org