You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Dan Kirkwood <da...@apache.org> on 2017/01/20 19:34:45 UTC

[VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Hello Incubator PMC,

The Apache Traffic Control community has voted on and approved a
proposal to release Apache Traffic Control 1.8.0-incubating.  We now
kindly request that the Incubator PMC members review and vote on this
incubator release.

The VOTE RESULT is here:

https://lists.apache.org/thread.html/64b9ffad20aca8a4af3bdb0ce33c2d2a26c24c48d96c31494acdca9d@%3Cdev.trafficcontrol.apache.org%3E

The draft release notes (along with links to artifacts,
signatures/checksums, and updated documentation) can be found here:

http://trafficcontrol.incubator.apache.org/downloads/

The git tag for the repository is "RELEASE-1.8.0-RC8":
https://github.com/apache/incubator-trafficcontrol/releases/tag/RELEASE-1.8.0-RC8

The source distribution (also linked in the release notes) is here:

https://dist.apache.org/repos/dist/dev/incubator/trafficcontrol/1.8.0/RC8/

Build instructions are included in the BUILD.md file which is
included in the source artifact.

Artifacts have been signed with the "dangogh@apache.org" key listed in:

https://dist.apache.org/repos/dist/dev/incubator/trafficcontrol/KEYS

Please review and vote:

[  ] +1 Approve the release
[  ] -1 Don't approve the release (please provide specific comments)

This vote will be open for at least 72 hours.

Thanks,

- Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Dan Kirkwood <da...@gmail.com>.
normalize.css should be as simple as adding this in the LICENSE under
the "For the bootstrap component",  since that's what is in the
bootstrap.css file.

/*! normalize.css v3.0.1 | MIT License | git.io/normalize */

And yes -- we neglected to remove the progress bar license from that
file when we removed the source..

I'll have a PR shortly to address a couple of these.  We'll chat again
on Monday.

Thanks,  guys...

On Fri, Jan 20, 2017 at 6:16 PM, Chris Lemmons <al...@gmail.com> wrote:
> I had the same thought. Dan and I have been running RAT (
> https://creadur.apache.org/rat/ ) and it runs clean against 1.8. However,
> it gets tricked by things with incorrect apache headers. At one point, we
> ran a "fix all" that added apache headers to our files. It was a little
> aggressive and caught some dependent files. I don't currently know of a
> tool that would find these files.
>
> For normalize.css, I'm a little confused. Unless I'm missing it somewhere
> else, it's only included wholesale as part of bootstrap.css. We do need to
> include the dependent license, though, he's right. I'm just not entirely
> sure how one goes about finding similar issues.
>
> WebAppers was just an ordinary mistake. We stripped it from the repo to
> avoid messing with the license and didn't get it removed from the LICENSE
> file.
>
> I'm relatively confident that the MaxMind CC-SA is fine, but we probably do
> need to run it past Apache Legal.
>
> Several of the issues he brought up are already fixed in master (due to
> them not having the bad header, so they got found there), so that's easy to
> backport. I'm hoping there's a tool for auditing, though.
>
> On Fri, Jan 20, 2017 at 6:01 PM Jan van Doorn <jv...@knutsel.com> wrote:
>
>> Saw that… :(
>>
>> Do we have the same tools that Justin has to check these license things?
>> If not, should we ask?
>>
>> I’ve been focusing on the functionality, not on this license stuff, but
>> I’m willing to help out if that can make a difference?
>>
>> Rgds,
>> JvD
>>
>>
>>
>> > On Jan 20, 2017, at 5:28 PM, Eric Friedrich (efriedri) <
>> efriedri@cisco.com> wrote:
>> >
>> >
>> > ________________________________________
>> > From: Justin Mclean [justin@classsoftware.com]
>> > Sent: Friday, January 20, 2017 6:20 PM
>> > To: general@incubator.apache.org
>> > Subject: Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)
>> >
>> > Hi,
>> >
>> > Sorry but it’s -1 (binding) as licensing issues and file headers
>> reported last release that were not fixed.
>> >
>> > I checked:
>> > - names include incubating
>> > - signature and hashes are OK
>> > - disclaimer exits
>> > - LICENSE still has issues brought up from last release
>> > - NOTICE is OK but has wrong year
>> > - Source files have ASF header. A couple of files have them incorrectly.
>> > - No unexpected binary files in release.
>> >
>> > While some of the issues brought up in last release have been fixed,
>> there a large number that look like they haven’t.
>> >
>> > LICENSE Is still missing licenses for jQuery UI, normalize.css, angular
>> loading bar, lz-string (which also incorrectly has an ASF header on it),
>> pretty print  (and which also has an incorrectly added ASF header) and
>> modernizr. They may be others. Also the dual licensing for select2.js has
>> not been dealt with and nor has the licensing of multiple font files.
>> >
>> > LICENSE also includes WebAppers Progress Bar which as pointed out last
>> release is Category B and cannot be included in a source release.
>> >
>> > Re licensing around the MaxMind DB GeoLite2 Database [1] (under a CC
>> share-alike license) also IMO needs to be sorted. I’m not sure it
>> classifies as "unmodified media”, best to ask on legal discuss.
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1. ./traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>>
>>

Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Chris Lemmons <al...@gmail.com>.
I had the same thought. Dan and I have been running RAT (
https://creadur.apache.org/rat/ ) and it runs clean against 1.8. However,
it gets tricked by things with incorrect apache headers. At one point, we
ran a "fix all" that added apache headers to our files. It was a little
aggressive and caught some dependent files. I don't currently know of a
tool that would find these files.

For normalize.css, I'm a little confused. Unless I'm missing it somewhere
else, it's only included wholesale as part of bootstrap.css. We do need to
include the dependent license, though, he's right. I'm just not entirely
sure how one goes about finding similar issues.

WebAppers was just an ordinary mistake. We stripped it from the repo to
avoid messing with the license and didn't get it removed from the LICENSE
file.

I'm relatively confident that the MaxMind CC-SA is fine, but we probably do
need to run it past Apache Legal.

Several of the issues he brought up are already fixed in master (due to
them not having the bad header, so they got found there), so that's easy to
backport. I'm hoping there's a tool for auditing, though.

On Fri, Jan 20, 2017 at 6:01 PM Jan van Doorn <jv...@knutsel.com> wrote:

> Saw that… :(
>
> Do we have the same tools that Justin has to check these license things?
> If not, should we ask?
>
> I’ve been focusing on the functionality, not on this license stuff, but
> I’m willing to help out if that can make a difference?
>
> Rgds,
> JvD
>
>
>
> > On Jan 20, 2017, at 5:28 PM, Eric Friedrich (efriedri) <
> efriedri@cisco.com> wrote:
> >
> >
> > ________________________________________
> > From: Justin Mclean [justin@classsoftware.com]
> > Sent: Friday, January 20, 2017 6:20 PM
> > To: general@incubator.apache.org
> > Subject: Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)
> >
> > Hi,
> >
> > Sorry but it’s -1 (binding) as licensing issues and file headers
> reported last release that were not fixed.
> >
> > I checked:
> > - names include incubating
> > - signature and hashes are OK
> > - disclaimer exits
> > - LICENSE still has issues brought up from last release
> > - NOTICE is OK but has wrong year
> > - Source files have ASF header. A couple of files have them incorrectly.
> > - No unexpected binary files in release.
> >
> > While some of the issues brought up in last release have been fixed,
> there a large number that look like they haven’t.
> >
> > LICENSE Is still missing licenses for jQuery UI, normalize.css, angular
> loading bar, lz-string (which also incorrectly has an ASF header on it),
> pretty print  (and which also has an incorrectly added ASF header) and
> modernizr. They may be others. Also the dual licensing for select2.js has
> not been dealt with and nor has the licensing of multiple font files.
> >
> > LICENSE also includes WebAppers Progress Bar which as pointed out last
> release is Category B and cannot be included in a source release.
> >
> > Re licensing around the MaxMind DB GeoLite2 Database [1] (under a CC
> share-alike license) also IMO needs to be sorted. I’m not sure it
> classifies as "unmodified media”, best to ask on legal discuss.
> >
> > Thanks,
> > Justin
> >
> > 1. ./traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>

Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Jan van Doorn <jv...@knutsel.com>.
Saw that… :( 

Do we have the same tools that Justin has to check these license things? If not, should we ask?

I’ve been focusing on the functionality, not on this license stuff, but I’m willing to help out if that can make a difference?

Rgds,
JvD



> On Jan 20, 2017, at 5:28 PM, Eric Friedrich (efriedri) <ef...@cisco.com> wrote:
> 
> 
> ________________________________________
> From: Justin Mclean [justin@classsoftware.com]
> Sent: Friday, January 20, 2017 6:20 PM
> To: general@incubator.apache.org
> Subject: Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)
> 
> Hi,
> 
> Sorry but it’s -1 (binding) as licensing issues and file headers reported last release that were not fixed.
> 
> I checked:
> - names include incubating
> - signature and hashes are OK
> - disclaimer exits
> - LICENSE still has issues brought up from last release
> - NOTICE is OK but has wrong year
> - Source files have ASF header. A couple of files have them incorrectly.
> - No unexpected binary files in release.
> 
> While some of the issues brought up in last release have been fixed, there a large number that look like they haven’t.
> 
> LICENSE Is still missing licenses for jQuery UI, normalize.css, angular loading bar, lz-string (which also incorrectly has an ASF header on it), pretty print  (and which also has an incorrectly added ASF header) and modernizr. They may be others. Also the dual licensing for select2.js has not been dealt with and nor has the licensing of multiple font files.
> 
> LICENSE also includes WebAppers Progress Bar which as pointed out last release is Category B and cannot be included in a source release.
> 
> Re licensing around the MaxMind DB GeoLite2 Database [1] (under a CC share-alike license) also IMO needs to be sorted. I’m not sure it classifies as "unmodified media”, best to ask on legal discuss.
> 
> Thanks,
> Justin
> 
> 1. ./traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


FW: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by "Eric Friedrich (efriedri)" <ef...@cisco.com>.
________________________________________
From: Justin Mclean [justin@classsoftware.com]
Sent: Friday, January 20, 2017 6:20 PM
To: general@incubator.apache.org
Subject: Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Hi,

Sorry but it’s -1 (binding) as licensing issues and file headers reported last release that were not fixed.

I checked:
- names include incubating
- signature and hashes are OK
- disclaimer exits
- LICENSE still has issues brought up from last release
- NOTICE is OK but has wrong year
- Source files have ASF header. A couple of files have them incorrectly.
- No unexpected binary files in release.

While some of the issues brought up in last release have been fixed, there a large number that look like they haven’t.

LICENSE Is still missing licenses for jQuery UI, normalize.css, angular loading bar, lz-string (which also incorrectly has an ASF header on it), pretty print  (and which also has an incorrectly added ASF header) and modernizr. They may be others. Also the dual licensing for select2.js has not been dealt with and nor has the licensing of multiple font files.

LICENSE also includes WebAppers Progress Bar which as pointed out last release is Category B and cannot be included in a source release.

Re licensing around the MaxMind DB GeoLite2 Database [1] (under a CC share-alike license) also IMO needs to be sorted. I’m not sure it classifies as "unmodified media”, best to ask on legal discuss.

Thanks,
Justin

1. ./traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Fwd: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Jan van Doorn <jv...@knutsel.com>.
FYI. I think we should certainly take him up on the kind offer to check out the release when it’s up for vote on our dev list.

> Begin forwarded message:
> 
> From: Justin Mclean <ju...@classsoftware.com>
> Subject: Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)
> Date: January 20, 2017 at 7:03:33 PM MST
> To: general@incubator.apache.org
> Reply-To: general@incubator.apache.org
> 
> Hi,
> 
>> Thanks again for your time checking our release, and sorry we’re still not there. 
> 
> It’s a complex release and may take a little while to get right, and it ’s certainly not expected that you get everything right while in the incubator.
> 
> In this case the issues where raised with the last release and not fixed. Do you have these issues recorded in JIRA? That a good way to remember they need to be done before the next release.
> 
> Also you still may get enough other people to voting +1 on this release (a -1 is not a veto) or you or someone else could change my mind.
> 
>> We’ve been running https://creadur.apache.org/rat/ <https://creadur.apache.org/rat/>
> 
> Rat is a very useful tool, but it wont catch everything and only knows about a limited number of licenses.
> 
>> - is there anything else that you use that we can also use? Any tips you have for us to get through this?
> 
> Just follow [1] it gives clear instruction off how to deal with most cases. [2] is also a help when it come to allowed 3rd party code. Your mentors should also be able to help here.
> 
> If you want me to take a look at when it comes up on your dev list, before offering it up for voting on the incubator list, just ask.
> 
> Thanks,
> Justin
> 
> 1. http://www.apache.org/dev/licensing-howto.html
> 2. https://www.apache.org/legal/resolved
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> Thanks again for your time checking our release, and sorry we’re still not there. 

It’s a complex release and may take a little while to get right, and it ’s certainly not expected that you get everything right while in the incubator.

In this case the issues where raised with the last release and not fixed. Do you have these issues recorded in JIRA? That a good way to remember they need to be done before the next release.

Also you still may get enough other people to voting +1 on this release (a -1 is not a veto) or you or someone else could change my mind.

> We’ve been running https://creadur.apache.org/rat/ <https://creadur.apache.org/rat/>

Rat is a very useful tool, but it wont catch everything and only knows about a limited number of licenses.

>  - is there anything else that you use that we can also use? Any tips you have for us to get through this?

Just follow [1] it gives clear instruction off how to deal with most cases. [2] is also a help when it come to allowed 3rd party code. Your mentors should also be able to help here.

If you want me to take a look at when it comes up on your dev list, before offering it up for voting on the incubator list, just ask.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html
2. https://www.apache.org/legal/resolved
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Jan van Doorn <jv...@knutsel.com>.
Hi Justin, 

Thanks again for your time checking our release, and sorry we’re still not there. 

We’ve been running https://creadur.apache.org/rat/ <https://creadur.apache.org/rat/>  - is there anything else that you use that we can also use? Any tips you have for us to get through this?

Best Regards,
JvD


> On Jan 20, 2017, at 4:20 PM, Justin Mclean <ju...@classsoftware.com> wrote:
> 
> Hi,
> 
> Sorry but it’s -1 (binding) as licensing issues and file headers reported last release that were not fixed.
> 
> I checked:
> - names include incubating
> - signature and hashes are OK
> - disclaimer exits
> - LICENSE still has issues brought up from last release
> - NOTICE is OK but has wrong year
> - Source files have ASF header. A couple of files have them incorrectly.
> - No unexpected binary files in release.
> 
> While some of the issues brought up in last release have been fixed, there a large number that look like they haven’t.
> 
> LICENSE Is still missing licenses for jQuery UI, normalize.css, angular loading bar, lz-string (which also incorrectly has an ASF header on it), pretty print  (and which also has an incorrectly added ASF header) and modernizr. They may be others. Also the dual licensing for select2.js has not been dealt with and nor has the licensing of multiple font files.
> 
> LICENSE also includes WebAppers Progress Bar which as pointed out last release is Category B and cannot be included in a source release.
> 
> Re licensing around the MaxMind DB GeoLite2 Database [1] (under a CC share-alike license) also IMO needs to be sorted. I’m not sure it classifies as "unmodified media”, best to ask on legal discuss.
> 
> Thanks,
> Justin
> 
> 1. ./traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


Re: [VOTE] Release Apache Traffic Control 1.8.0-incubating (RC8)

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Sorry but it’s -1 (binding) as licensing issues and file headers reported last release that were not fixed.

I checked:
- names include incubating
- signature and hashes are OK
- disclaimer exits
- LICENSE still has issues brought up from last release
- NOTICE is OK but has wrong year
- Source files have ASF header. A couple of files have them incorrectly.
- No unexpected binary files in release.

While some of the issues brought up in last release have been fixed, there a large number that look like they haven’t.

LICENSE Is still missing licenses for jQuery UI, normalize.css, angular loading bar, lz-string (which also incorrectly has an ASF header on it), pretty print  (and which also has an incorrectly added ASF header) and modernizr. They may be others. Also the dual licensing for select2.js has not been dealt with and nor has the licensing of multiple font files.

LICENSE also includes WebAppers Progress Bar which as pointed out last release is Category B and cannot be included in a source release.

Re licensing around the MaxMind DB GeoLite2 Database [1] (under a CC share-alike license) also IMO needs to be sorted. I’m not sure it classifies as "unmodified media”, best to ask on legal discuss.

Thanks,
Justin

1. ./traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org