You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by dl...@apache.org on 2019/09/10 05:09:07 UTC

[asterixdb] branch master updated: [NO ISSUE][COMP] Increase memory budget for window operator

This is an automated email from the ASF dual-hosted git repository.

dlych pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 309b96f  [NO ISSUE][COMP] Increase memory budget for window operator
309b96f is described below

commit 309b96f8d7a266c0d9e986bb294f611c065c4909
Author: Dmitry Lychagin <dm...@couchbase.com>
AuthorDate: Mon Sep 9 15:37:11 2019 -0700

    [NO ISSUE][COMP] Increase memory budget for window operator
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    - Increase default memory budget for a window operator
      from 4MB to 32MB
    
    Change-Id: I6902d5e730232892f22e36598389309e8bc909c3
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/3551
    Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
    Reviewed-by: Ali Alsuliman <al...@gmail.com>
---
 .../main/java/org/apache/asterix/common/config/CompilerProperties.java | 2 +-
 asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md | 3 +++
 asterixdb/asterix-doc/src/site/markdown/ncservice.md                   | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
index 7c67b96..b8d73be 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
@@ -45,7 +45,7 @@ public class CompilerProperties extends AbstractProperties {
                 "The memory budget (in bytes) for a group by operator instance in a partition"),
         COMPILER_WINDOWMEMORY(
                 LONG_BYTE_UNIT,
-                StorageUtil.getLongSizeInBytes(4L, MEGABYTE),
+                StorageUtil.getLongSizeInBytes(32L, MEGABYTE),
                 "The memory budget (in bytes) for a window operator instance in a partition"),
         COMPILER_TEXTSEARCHMEMORY(
                 LONG_BYTE_UNIT,
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
index 88b080f..f87771b 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
@@ -65,6 +65,9 @@ The supported configurable memory parameters are:
 *  **compiler.joinmemory**: the memory budget that each parallel hash join operator instance can use;
    32MB is the default budget.
 
+*  **compiler.windowmemory**: the memory budget that each parallel window aggregate operator instance can use;
+   32MB is the default budget.
+
 For each memory budget value, you can use a 64-bit integer value
 with a 1024-based binary unit suffix (for example, B, KB, MB, GB).
 If there is no user-provided suffix, "B" is the default suffix. See the following examples.
diff --git a/asterixdb/asterix-doc/src/site/markdown/ncservice.md b/asterixdb/asterix-doc/src/site/markdown/ncservice.md
index 9ef3de1..8d1a8cd 100644
--- a/asterixdb/asterix-doc/src/site/markdown/ncservice.md
+++ b/asterixdb/asterix-doc/src/site/markdown/ncservice.md
@@ -348,7 +348,7 @@ The following parameters are configured under the "[common]" section.
 | common  | compiler.sort.parallel                    | Enable full parallel sort for queries | true |
 | common  | compiler.sort.samples                     | The number of samples taken from each partition to guide the sort operation when full parallel sort is enabled | 100 |
 | common  | compiler.textsearchmemory                 | The memory budget (in bytes) for an inverted-index-search operator instance in a partition | 33554432 (32 MB) |
-| common  | compiler.windowmemory                     | The memory budget (in bytes) for a window operator instance in a partition | 4194304 (4 MB) |
+| common  | compiler.windowmemory                     | The memory budget (in bytes) for a window operator instance in a partition | 33554432 (32 MB) |
 | common  | log.level                                 | The logging level for master and slave processes | WARNING |
 | common  | max.wait.active.cluster                   | The max pending time (in seconds) for cluster startup. After the threshold, if the cluster still is not up and running, it is considered unavailable | 60 |
 | common  | messaging.frame.count                     | Number of reusable frames for NC to NC messaging | 512 |