You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2016/09/07 16:52:53 UTC
[GitHub] incubator-carbondata pull request #139: Fixed data mismatch issue in case of...
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/139
Fixed data mismatch issue in case of Dictionary Exclude column for Numeric data type
Problem: In case of greater than query on dictionary exclude column of for numeric data type
This is because data is sorted based on string because of this if data is 1,10,2,3 , data will be sorted like 1,10,2,3 but if we search greater than 3 then while applying min max will return false as last value is 3
Solution:we need to sort based on actual data type for this we should have chain comparator based on data type while loading the data, currently disabling DictionaryExclude column for numeric data type and will throw exception. Will raise jira issue to for sorting the based on actual data type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata DataMismatchInCaseOfDictionaryExcludeColumnForNumericDataType
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit 2200fb17887d0fad9175ee4d67f2b6ceb437639f
Author: kumarvishal <ku...@gmail.com>
Date: 2016-09-07T16:46:17Z
Fixed data mismatch issue in case of Dictionary Exclude column for Numeric data type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #139: [CARBONDATA-224]Fixed data mismatch ...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/139#discussion_r77947424
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -864,8 +864,8 @@ class CarbonSqlParser()
/**
* detects whether double or decimal column is part of dictionary_exclude
*/
- def isDoubleDecimalColDictionaryExclude(columnDataType: String): Boolean = {
- val dataTypes = Array("double", "decimal")
+ def isNumberInColDictionaryExclude(columnDataType: String): Boolean = {
+ val dataTypes = Array("double", "decimal", "int")
--- End diff --
Add a reverse check that only string or (varchar-check) is only supported. As other datatypes like bigint etc will have problem in above check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #139: [CARBONDATA-224]Fixed data mismatch ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/139#discussion_r77950911
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -864,8 +864,8 @@ class CarbonSqlParser()
/**
* detects whether double or decimal column is part of dictionary_exclude
*/
- def isDoubleDecimalColDictionaryExclude(columnDataType: String): Boolean = {
- val dataTypes = Array("double", "decimal")
+ def isNumberInColDictionaryExclude(columnDataType: String): Boolean = {
+ val dataTypes = Array("double", "decimal", "int")
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #139: [CARBONDATA-224]Fixed data mismatch ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---