You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "RobbertDM (via GitHub)" <gi...@apache.org> on 2023/03/27 16:37:42 UTC
[GitHub] [hive] RobbertDM opened a new pull request, #4160: remove toLowerCases
RobbertDM opened a new pull request, #4160:
URL: https://github.com/apache/hive/pull/4160
Hi there,
Excuse my unconventional approach, I couldn't find an 'issues' button, so I decided to use this one.
I'm very curious to know:
Why does hive cast to lowercase?
Seems like this is causing some trouble here and there. Is it a realistic option for hive to also support uppercase column names in tables?
Best regards and thanks for all the hard work!
Robbert
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] RobbertDM commented on pull request #4160: remove toLowerCases
Posted by "RobbertDM (via GitHub)" <gi...@apache.org>.
RobbertDM commented on PR #4160:
URL: https://github.com/apache/hive/pull/4160#issuecomment-1494417049
Ah well, we use [trino](https://trino.io), and we have multiple databases/connectors connected to that trino, one of them being hive metastore, another being some database that supports uppercase column names, say postgres.
What we do is load some tables with uppercase column names from postgres and copy them to iceberg files through hive metastore.
Then, after a few days, we want to check whether our iceberg table is still up to date, so we compare it to the postgres one. We start by comparing the schemas, and notice that some `COLUMN_NAMES` are missing, and that there are some `column_names` in our hive connector that are not present anymore in postgres. Of course, they're the same, they just got cast to lowercase somewhere along the copy.
Here's the issue we ran into, it's a bit more specific but the general idea is the same:
https://github.com/dbt-labs/dbt-core/issues/7084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on pull request #4160: remove toLowerCases
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on PR #4160:
URL: https://github.com/apache/hive/pull/4160#issuecomment-1494375699
I do not have historical knowledge about it, but this change seems pretty risky. I guess there are several other components that are rely on these names. Also in some environment we would like to reduce the possibility to not play with CamelCases. I guess there are a lot of tests and other components are rely on these names in lower case. Also these are mainly for comparison as I see.
@ayushtkn @deniskuzZ do you know the history of the toLowerCase()?
@RobbertDM Why this is an issue for you? Is it blocking some development? Or just bothering your eyes? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] RobbertDM commented on pull request #4160: remove toLowerCases
Posted by "RobbertDM (via GitHub)" <gi...@apache.org>.
RobbertDM commented on PR #4160:
URL: https://github.com/apache/hive/pull/4160#issuecomment-1495736942
Ok, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] RobbertDM closed pull request #4160: remove toLowerCases
Posted by "RobbertDM (via GitHub)" <gi...@apache.org>.
RobbertDM closed pull request #4160: remove toLowerCases
URL: https://github.com/apache/hive/pull/4160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org