[GitHub] [maven-checkstyle-plugin] romani commented on a change in pull request #28: [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle

[GitBox <gi...@apache.org>]

romani commented on a change in pull request #28: [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle
URL: https://github.com/apache/maven-checkstyle-plugin/pull/28#discussion_r386764551
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
 ##########
 @@ -314,6 +314,13 @@ public URLClassLoader run()
         try
         {
             checker.setClassLoader( projectClassLoader );
+            /*
+             * MCHECKSTYLE-387: If the previous method call was successful, emit a warning that the user is using
+             * an old version of checkstyle.
+             */
+            getLogger().warn( "Old version of checkstyle detected. Consider updating to >= v8.30" );
+            getLogger().warn( "For more information see: "
+                + "https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html" );
         }
         catch ( NoSuchMethodError ignored )
 
 Review comment:
   My comment is false alarm, old version was used , see good comment at https://github.com/checkstyle/checkstyle/issues/7190#issuecomment-593261410 .
   
   This review point is resolved. Thanks a lot for help. This commit change is good extra messages is always good for users.
   
   Off topic but in reply to comments above:
   
   >Seems to me it might get steered better if it were under guidence of checkstyle team (proviced expertice with maven bits is there). 
   
   Yes, but there is a problem - checkstyle core library team is tiny. We have huge amount of PRs that are waiting for review each day. No matter how hard we work we never able to reach to zero active PRs for few years.  Each day we get new PRs. .... Maven plugin does not depends on metadata of core library that makes him skip huge amount of problems as other plugins has. All plugins that are eventually endup in our organization are plugins that heavily depends on checkstyle metadata about Checks, maintenance of them is hard ( I hope will be resolved ). 
   It doesn't really matter where project is hosting, it is matter who maintain it. I can open gate and let somebody move project to be hosted in our organization, but if no extra heads and hands ... It will stay the same.
   @bmhm , do you have more interest to contribute if it becomes non Apache project ?
   
   >library did not bother to keep any semantic versioning. 
   
   This is not true. We strictly(did bad version bump only ones) follow versioning except for first number ( it is reserved for huge update , like min jdk version bump). Second digit do mean update in API/metadata/... . Third digit means upgrade is safe for all plugins, only bugs we're fixed. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services