You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by sardell <gi...@git.apache.org> on 2018/04/19 11:46:25 UTC
[GitHub] metron pull request #998: METRON-1530: Default proxy config settings in metr...
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/998
METRON-1530: Default proxy config settings in metron-contrib need to be updated
## Contributor Comments
The default target settings inside of metron-config's proxy.conf.json file resulted in Gateway Timeout errors in the browser. I was able to resolve this by matching the settings inside of metron-alerts' proxy file.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sardell/metron METRON-1530
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/998.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #998
----
commit 18410187024fb0512b5ceb5c0c1fab016aba4326
Author: Shane Ardell <sa...@...>
Date: 2018-04-19T10:12:33Z
update proxy settings in metron-config
----
---
[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/998
The "/search" and "/_cluster" entries aren't necessary here (and should probably be removed from the metron-alerts proxy file too). Other than that this looks good.
---
[GitHub] metron pull request #998: METRON-1530: Default proxy config settings in metr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/998
---
[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/998
Yes +1 from me.
---
[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...
Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/998
LGTM @merrimanr are you +1 on this now?
---