You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/27 08:08:58 UTC

[GitHub] [bookkeeper] hangc0276 opened a new pull request #3144: Revert rocksdb compaction on checkpoint to reduce cpu intensive

hangc0276 opened a new pull request #3144:
URL: https://github.com/apache/bookkeeper/pull/3144


   ### Motivation
   https://github.com/apache/bookkeeper/pull/2686 introduce RocksDB compaction on checkpoint to fix seeking RocksDB metadata timeout issue. However, trigger RocksDB compaction is a heavy operation and the checkpoint will be triggered in high frequency, which cause db-storage-cleanup thread always into high load, and make the cpu keeps 100%. https://github.com/apache/bookkeeper/pull/2686#issuecomment-1065893543 
   
   Related logs: https://github.com/apache/bookkeeper/pull/2686#issuecomment-1065888832
    
   In order to fix this issue, we divide into two steps.
   1. Remove the compactRange logic in during checkpoint
   2. Figure out smarter solution for deleted entry compaction in RocksDB
   
   This is the first part.
   
   I have sent a discuss into dev mail list.
   https://lists.apache.org/thread/jkfbodv6xv2szz8ldb5mvkb00hoor5yj
   
   
   ### Changes
   1. Remove the compactRange logic during checkpoint.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] hangc0276 commented on pull request #3144: Revert rocksdb compaction on checkpoint to reduce cpu intensive

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #3144:
URL: https://github.com/apache/bookkeeper/pull/3144#issuecomment-1080073632


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] eolivelli merged pull request #3144: Revert rocksdb compaction on checkpoint to reduce cpu intensive

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #3144:
URL: https://github.com/apache/bookkeeper/pull/3144


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] dlg99 commented on pull request #3144: Revert rocksdb compaction on checkpoint to reduce cpu intensive

Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #3144:
URL: https://github.com/apache/bookkeeper/pull/3144#issuecomment-1081215833


   @mauricebarnum please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org