You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/26 15:02:58 UTC
[GitHub] [airflow] nivangio opened a new issue, #23262: Parsing error of email_conn_id on utils/email.py
nivangio opened a new issue, #23262:
URL: https://github.com/apache/airflow/issues/23262
### Apache Airflow version
2.2.2
### What happened
When picking `email_conn_id` from Secrets Manager, the connection is correctly retrieved from ASM but parsed as an URI. For that reason, `login` and `password` parameters are left empty and therefore not picked in `send_mime_email` (lines 189,190).
The connection is stored as follows:
`{"login": "my_email@adress.com",
"password": "my_password"}`
### What you think should happen instead
_No response_
### How to reproduce
_No response_
### Operating System
Ubuntu 20.04
### Versions of Apache Airflow Providers
_No response_
### Deployment
Docker-Compose
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Parsing error of email_conn_id on utils/email.py [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-2788537876
This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activity on this issue. Kindly asking to recheck the report against latest Airflow version and let us know if the issue is reproducible. The issue will be closed in next 30 days if no further activity occurs from the issue author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #23262: Parsing error of email_conn_id on utils/email.py
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-1109909217
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nivangio commented on issue #23262: Parsing error of email_conn_id on utils/email.py
Posted by GitBox <gi...@apache.org>.
nivangio commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-1110091110
I finally managed to do it. It required for me to set `conn_type`, `port` and `host` in the connection secret in AWS (I'm working with `full_url_mode: false`) as well as placing them in the config because if the URI is not full `username` and `password` are not correctly parsed
It'd be nice to have just one set-up instead. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #23262: Parsing error of email_conn_id on utils/email.py
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-1109956328
> The connection is stored as follows:
>
> {"login": "my_email@adress.com", "password": "my_password"}
According to the documentation, the connection should be written as a URI.
> You can store the different values for a secret in two forms: storing the conn URI in one field (default mode) or using different fields in Amazon Secrets Manager (setting full_url_mode as false in the backend config), as follows:
https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html
By default, we use URI formaat, so you should use the following command to set URI:
```
aws secretsmanager put-secret-value \
--secret-id airflow/connections/smtp_default \
--secret-string "smtps://user:host@relay.example.com:465"
```
https://airflow.apache.org/docs/apache-airflow-providers-amazon/2.2.0/secrets-backends/aws-secrets-manager.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Parsing error of email_conn_id on utils/email.py [airflow]
Posted by "hegdeadithyak (via GitHub)" <gi...@apache.org>.
hegdeadithyak commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-2033448735
@potiuk
Please let me know if this is still unassigned and if you'd be happy for me to take it on.
I'm interested in working on this issue. Before I dive in, I wanted to check if there's anything specific I should keep in mind while working on it, or if someone else has already claimed it.
Thanks,
**Adithya Hegde Kota**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dbqinhust commented on issue #23262: Parsing error of email_conn_id on utils/email.py
Posted by "dbqinhust (via GitHub)" <gi...@apache.org>.
dbqinhust commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-1730058582
Could you assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #23262: Parsing error of email_conn_id on utils/email.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #23262:
URL: https://github.com/apache/airflow/issues/23262#issuecomment-1114042515
Yeah. PRs to fix it are most welcome @nivangio !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org