You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/09/29 21:52:34 UTC
[PR] HDDS-13721. Move admin interface usage out of hdds-common [ozone]
adoroszlai opened a new pull request, #9082:
URL: https://github.com/apache/ozone/pull/9082
## What changes were proposed in this pull request?
Some proto generated code (`StorageContainerLocationProtocolProtos`) from `hdds-interface-admin` is currently used by some classes in `hdds-common`:
```
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/token/ContainerTokenIdentifier.java
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java
```
These classes in turn are only used in admin CLI, server components and tests, but not in common and clients. Thus, we can move these classes out of `hdds-common`, and remove the `hdds-common -> hdds-interface-admin` dependency.
https://issues.apache.org/jira/browse/HDDS-13721
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/18109297738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13721. Move admin interface usage out of hdds-common [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #9082:
URL: https://github.com/apache/ozone/pull/9082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13721. Move admin interface usage out of hdds-common [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9082:
URL: https://github.com/apache/ozone/pull/9082#issuecomment-3387496112
Thanks @errose28, @sarvekshayr for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org