You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/11/21 20:23:15 UTC
[GitHub] [incubator-echarts] 100pah commented on issue #11632: feat(pie):
support align to edge and labelLine mode #11381
100pah commented on issue #11632: feat(pie): support align to edge and labelLine mode #11381
URL: https://github.com/apache/incubator-echarts/pull/11632#issuecomment-557256850
#### (1)
In the `pie-alignTo.html`, slide the 'minLength2' in the "contoller panel" util all of the labels disappear in the first pie, and slide back. the labels will not be displayed any more. And during this option, the text will become more and more.
I don't know whether it is a problem.
#### (2)
I have test this case: more than one pie charts in one echarts instance.
```js
function makeData() {
var count = 10;
var data = [];
var text = '';
for (var i = 0; i < count; i++) {
text += 'X';
data.push({
name: text + i,
value: Math.random()
});
}
return data;
}
var option0 = {
series: [{
type: 'pie',
radius: '25%',
center: ['25%', '50%'],
data: makeData(),
// animation: false,
labelLine: {
minLength2: 50,
maxLength2: 10
},
label: {
// edgeMargin: 20,
position: 'outer',
alignTo: 'edge',
padding: 5
}
}, {
type: 'pie',
radius: '25%',
center: ['75%', '50%'],
data: makeData(),
// animation: false,
labelLine: {
minLength2: 50,
maxLength2: 10
},
label: {
// edgeMargin: 20,
position: 'outer',
alignTo: 'labelLine',
padding: 5
}
}]
};
```
The result seams buggy.
#### (3)
I am not sure about the config `edgeMargin`. It seams define the gap between "a pie chart" and the dom container. But if consider there are more than one pie charts in one dom container, do we also need to consider the gap between different pie charts?
That is, do we need to define a rect area with `left/right/top/bottom/width/height` but not a `edgeMargin`? I am not sure. @Ovilia @pissang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org