You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/11 05:16:12 UTC
[GitHub] [airflow] potiuk opened a new pull request #11413: Adds missing schema for kerberos sidecar configuration
potiuk opened a new pull request #11413:
URL: https://github.com/apache/airflow/pull/11413
The kerberos support added in #11130 did not have schema added
to the values.yml. This PR fixes it.
Co-authored-by: Jacob Ferriero <jf...@google.com>
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502967272
##########
File path: chart/values.schema.json
##########
@@ -796,6 +796,16 @@
}
}
},
+ "kerberosSidecar": {
+ "description": "Run a side car in each worker pod to refresh kerberos ccache with `airflow kerberos` according to the airflow secuirty configuration",
Review comment:
```suggestion
"description": "Run a side car in each worker pod to refresh Kerberos cache with `airflow kerberos` according to the airflow security configuration",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502953757
##########
File path: chart/values.schema.json
##########
@@ -796,6 +796,15 @@
}
}
},
+ "kerberosSidecar": {
+ "description": "Run a side car in each worker pod to refresh kerberos ccache with `airflow kerberos` according to the airflow secuirty configuration",
+ "type": "object",
+ "properties": {
+ "enabled": {
+ "description": "Enable kerberos side car on worker pods."
Review comment:
```suggestion
"description": "Enable kerberos side car on worker pods.",
"type": "boolean"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502967344
##########
File path: chart/values.schema.json
##########
@@ -1066,6 +1076,44 @@
}
}
}
+ },
+ "kerberos": {
+ "description": "Kerberos configurations for airflow",
+ "type": "object",
+ "properties": {
+ "enabled": {
+ "description": "Enable kerberos.",
+ "type": "boolean"
+ },
+ "ccacheMountPath": {
Review comment:
```suggestion
"cacheMountPath": {
```
##########
File path: chart/values.schema.json
##########
@@ -1066,6 +1076,44 @@
}
}
}
+ },
+ "kerberos": {
+ "description": "Kerberos configurations for airflow",
+ "type": "object",
+ "properties": {
+ "enabled": {
+ "description": "Enable kerberos.",
+ "type": "boolean"
+ },
+ "ccacheMountPath": {
+ "description": "Path to mount shared volume for kerberos credentials cache.",
+ "type": "string"
+ },
+ "ccacheFileName": {
Review comment:
```suggestion
"cacheFileName": {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502973097
##########
File path: chart/values.schema.json
##########
@@ -1066,6 +1076,44 @@
}
}
}
+ },
+ "kerberos": {
+ "description": "Kerberos configurations for airflow",
+ "type": "object",
+ "properties": {
+ "enabled": {
+ "description": "Enable kerberos.",
+ "type": "boolean"
+ },
+ "ccacheMountPath": {
+ "description": "Path to mount shared volume for kerberos credentials cache.",
+ "type": "string"
+ },
+ "ccacheFileName": {
Review comment:
aah, TIL :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502972948
##########
File path: chart/values.schema.json
##########
@@ -1066,6 +1076,44 @@
}
}
}
+ },
+ "kerberos": {
+ "description": "Kerberos configurations for airflow",
+ "type": "object",
+ "properties": {
+ "enabled": {
+ "description": "Enable kerberos.",
+ "type": "boolean"
+ },
+ "ccacheMountPath": {
Review comment:
Same as the other comment - The "ccache" is deliberate here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502953692
##########
File path: chart/values.schema.json
##########
@@ -796,6 +796,15 @@
}
}
},
+ "kerberosSidecar": {
+ "description": "Run a side car in each worker pod to refresh kerberos ccache with `airflow kerberos` according to the airflow secuirty configuration",
+ "type": "object",
+ "properties": {
+ "enabled": {
Review comment:
Good catch !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502952120
##########
File path: chart/values.schema.json
##########
@@ -796,6 +796,15 @@
}
}
},
+ "kerberosSidecar": {
+ "description": "Run a side car in each worker pod to refresh kerberos ccache with `airflow kerberos` according to the airflow secuirty configuration",
+ "type": "object",
+ "properties": {
+ "enabled": {
Review comment:
Missing a type here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#issuecomment-706651659
cc: @jaketf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #11413:
URL: https://github.com/apache/airflow/pull/11413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#issuecomment-706769674
All fixed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#issuecomment-706942348
How does it look now @ashb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11413: Adds missing schema for kerberos sidecar configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11413:
URL: https://github.com/apache/airflow/pull/11413#discussion_r502972506
##########
File path: chart/values.schema.json
##########
@@ -1066,6 +1076,44 @@
}
}
}
+ },
+ "kerberos": {
+ "description": "Kerberos configurations for airflow",
+ "type": "object",
+ "properties": {
+ "enabled": {
+ "description": "Enable kerberos.",
+ "type": "boolean"
+ },
+ "ccacheMountPath": {
+ "description": "Path to mount shared volume for kerberos credentials cache.",
+ "type": "string"
+ },
+ "ccacheFileName": {
Review comment:
"ccache" stands for "credential cache" and is pretty common in the Kerberos world. https://web.mit.edu/kerberos/krb5-1.12/doc/basic/ccache_def.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org