You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2019/01/23 11:47:13 UTC
Review Request 69817: Refactored 'support/verify-reviews.py' to be
closer to commit 7412179.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69817/
-----------------------------------------------------------
Review request for mesos, Till Toenshoff and Vinod Kone.
Repository: mesos
Description
-------
The goal of this commit is to make 'verify-reviews.py' as close as
possible to its last known working state (commit
74121798f24fca372180b8c4bc00b4df07d46240).
The diff between 'verify-reviews.py' at this commit and 7412179 is
available here: https://www.diffchecker.com/cmfaM83O All the new
features added since 7412179 have been added again and the code
has been made Python 3 compatible again.
The goal is to have a diff as minimal as possible with improvements
regarding logs so that we do not face CI issues anymore. Changes
have been made regarding how we run commands from the script so
that they are run from the repository instead of where the
script is being called.
Diffs
-----
support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9
Diff: https://reviews.apache.org/r/69817/diff/1/
Testing
-------
Thanks,
Armand Grillet
Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be
closer to commit 7412179.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69817/#review212319
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69817]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 23, 2019, 11:47 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69817/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 11:47 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The goal of this commit is to make 'verify-reviews.py' as close as
> possible to its last known working state (commit
> 74121798f24fca372180b8c4bc00b4df07d46240).
>
> The diff between 'verify-reviews.py' at this commit and 7412179 is
> available here: https://www.diffchecker.com/cmfaM83O All the new
> features added since 7412179 have been added again and the code
> has been made Python 3 compatible again.
>
> The goal is to have a diff as minimal as possible with improvements
> regarding logs so that we do not face CI issues anymore. Changes
> have been made regarding how we run commands from the script so
> that they are run from the repository instead of where the
> script is being called.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9
>
>
> Diff: https://reviews.apache.org/r/69817/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be
closer to commit 7412179.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69817/#review212668
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 23, 2019, 11:47 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69817/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 11:47 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The goal of this commit is to make 'verify-reviews.py' as close as
> possible to its last known working state (commit
> 74121798f24fca372180b8c4bc00b4df07d46240).
>
> The diff between 'verify-reviews.py' at this commit and 7412179 is
> available here: https://www.diffchecker.com/cmfaM83O All the new
> features added since 7412179 have been added again and the code
> has been made Python 3 compatible again.
>
> The goal is to have a diff as minimal as possible with improvements
> regarding logs so that we do not face CI issues anymore. Changes
> have been made regarding how we run commands from the script so
> that they are run from the repository instead of where the
> script is being called.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9
>
>
> Diff: https://reviews.apache.org/r/69817/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be
closer to commit 7412179.
Posted by Armand Grillet <ag...@mesosphere.io>.
> On Jan. 23, 2019, 8:55 p.m., Vinod Kone wrote:
> > Looks ok to me. I'll let Till ship this.
> >
> > Has this been tested?
I have tested the changes locally but this was also the case for previous review requests on this support script thus I am still not confident regarding the reliability of this script.
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69817/#review212250
-----------------------------------------------------------
On Jan. 23, 2019, 12:47 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69817/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 12:47 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The goal of this commit is to make 'verify-reviews.py' as close as
> possible to its last known working state (commit
> 74121798f24fca372180b8c4bc00b4df07d46240).
>
> The diff between 'verify-reviews.py' at this commit and 7412179 is
> available here: https://www.diffchecker.com/cmfaM83O All the new
> features added since 7412179 have been added again and the code
> has been made Python 3 compatible again.
>
> The goal is to have a diff as minimal as possible with improvements
> regarding logs so that we do not face CI issues anymore. Changes
> have been made regarding how we run commands from the script so
> that they are run from the repository instead of where the
> script is being called.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9
>
>
> Diff: https://reviews.apache.org/r/69817/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be
closer to commit 7412179.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69817/#review212250
-----------------------------------------------------------
Looks ok to me. I'll let Till ship this.
Has this been tested?
- Vinod Kone
On Jan. 23, 2019, 11:47 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69817/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 11:47 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The goal of this commit is to make 'verify-reviews.py' as close as
> possible to its last known working state (commit
> 74121798f24fca372180b8c4bc00b4df07d46240).
>
> The diff between 'verify-reviews.py' at this commit and 7412179 is
> available here: https://www.diffchecker.com/cmfaM83O All the new
> features added since 7412179 have been added again and the code
> has been made Python 3 compatible again.
>
> The goal is to have a diff as minimal as possible with improvements
> regarding logs so that we do not face CI issues anymore. Changes
> have been made regarding how we run commands from the script so
> that they are run from the repository instead of where the
> script is being called.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9
>
>
> Diff: https://reviews.apache.org/r/69817/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be
closer to commit 7412179.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69817/#review212232
-----------------------------------------------------------
PASS: Mesos patch 69817 was successfully built and tested.
Reviews applied: `['69817']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2810/mesos-review-69817
- Mesos Reviewbot Windows
On Jan. 23, 2019, 11:47 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69817/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 11:47 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The goal of this commit is to make 'verify-reviews.py' as close as
> possible to its last known working state (commit
> 74121798f24fca372180b8c4bc00b4df07d46240).
>
> The diff between 'verify-reviews.py' at this commit and 7412179 is
> available here: https://www.diffchecker.com/cmfaM83O All the new
> features added since 7412179 have been added again and the code
> has been made Python 3 compatible again.
>
> The goal is to have a diff as minimal as possible with improvements
> regarding logs so that we do not face CI issues anymore. Changes
> have been made regarding how we run commands from the script so
> that they are run from the repository instead of where the
> script is being called.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9
>
>
> Diff: https://reviews.apache.org/r/69817/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>