You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "vineet semwal (JIRA)" <ji...@apache.org> on 2012/05/18 12:20:08 UTC

[jira] [Comment Edited] (WICKET-4555) deprecate/remove pagingnavigator#getpagingnavigation()

    [ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278699#comment-13278699 ] 

vineet semwal edited comment on WICKET-4555 at 5/18/12 10:18 AM:
-----------------------------------------------------------------

i have taken a quick look at pagingnavigator and  pagingnavigation ,i think it's ok to initialize pagingnavigation in the constructor itself but you will need to test.. it's also quite ok to initialize it in onintialize  if you mention in the javadoc of getter that it's populated only after pagingnavigator#onitialize() ... 
                
      was (Author: vineetsemwal):
    i have taken a quick look at pagingnavigator and  pagingnavigation ,i think it's ok to initialize pagingnavigation in the constructor itself but you will need to test.. it's also quite ok to initialize it in onintialize  if you mention in the javadoc of getter that it's populated only after component#onitialize() ... 
                  
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
>                 Key: WICKET-4555
>                 URL: https://issues.apache.org/jira/browse/WICKET-4555
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 1.5.6, 6.0.0-beta1
>            Reporter: vineet semwal
>              Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation  field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira