You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/13 13:40:42 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #4601: Remove ObjectStore from FileStream (#4533)
tustvold opened a new pull request, #4601:
URL: https://github.com/apache/arrow-datafusion/pull/4601
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4533
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #4601: Remove ObjectStore from FileStream (#4533)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #4601:
URL: https://github.com/apache/arrow-datafusion/pull/4601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #4601: Remove ObjectStore from FileStream (#4533)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #4601:
URL: https://github.com/apache/arrow-datafusion/pull/4601#issuecomment-1351213597
I plan to merge this this afternoon, unless I hear any objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4601: Remove ObjectStore from FileStream (#4533)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4601:
URL: https://github.com/apache/arrow-datafusion/pull/4601#issuecomment-1351360451
Benchmark runs are scheduled for baseline = a5cf57789a73646b92ecefc1124cd38215b91ee7 and contender = 84d3ae8efe83ca9c0a988ed23ec66c647b9b7669. 84d3ae8efe83ca9c0a988ed23ec66c647b9b7669 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9b938231ac0d4dda9bed2929eec3b865...dc9ae14ce0ce48faabecf0f05e1f2911/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/90cfbcd0efb449a48ef9774ea84d4a6b...a1d86d04d832460c893564231b8c8825/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e81d6594d32d40bf9f751965ea66643f...27bb88d7f0ba48de8269a31c7deac957/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cfe6a982c55c4d4f9ce92e2407b02c2a...37442ec172ae416d8542c39e4a90e782/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Cheappie commented on pull request #4601: Remove ObjectStore from FileStream (#4533)
Posted by GitBox <gi...@apache.org>.
Cheappie commented on PR #4601:
URL: https://github.com/apache/arrow-datafusion/pull/4601#issuecomment-1351175136
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #4601: Remove ObjectStore from FileStream (#4533)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #4601:
URL: https://github.com/apache/arrow-datafusion/pull/4601#issuecomment-1349647791
> the rationale that any opener that needs a object_store reference should obtain one as part of construction (rather than requiring it on the trait)?
The rationale is that some users are not using ObjectStore at all, and are using ParquetFileReaderFactory to provide a custom AsyncFileReader to the parquet crate's async reader. The FileStream plumbing, however, still required an ObjectStore necessitating a dummy object to be propagated through only to be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org