You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/22 15:29:48 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #920: nimble/ll: Fix assert on aux unref during scan

andrzej-kaczmarek opened a new pull request #920:
URL: https://github.com/apache/mynewt-nimble/pull/920


   This fixes assert in ble_ll_scan_aux_data_unref() during scan under
   heavy load. This happens when we scanned an aux with auxptr, but we
   failed to schedule scan for pointed aux.
   
   What happens in above scenario is that scan error is already set due
   to failed scheduling, but we still send complete received aux. That
   is ok, but we do not check for error that is already set and do not
   mark data as truncated which results in an assert: if any data were
   sent to host, it's expected that we'll have either truncated or
   completed flag set on last unref.
   
   The fix is to set truncated flag properly on last chunk of data from
   mentioned aux.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #920: nimble/ll: Fix assert on aux unref during scan

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #920:
URL: https://github.com/apache/mynewt-nimble/pull/920


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #920: nimble/ll: Fix assert on aux unref during scan

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #920:
URL: https://github.com/apache/mynewt-nimble/pull/920#issuecomment-783457413


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org