[GitHub] [lucene-solr] romseygeek commented on a change in pull request #631: LUCENE-8750: implement setMissingValue for ValueSource sortFields

[GitBox <gi...@apache.org>]

romseygeek commented on a change in pull request #631: LUCENE-8750: implement setMissingValue for ValueSource sortFields
URL: https://github.com/apache/lucene-solr/pull/631#discussion_r271382275
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java
 ##########
 @@ -428,6 +428,16 @@ public DoubleValuesSource rewrite(IndexSearcher searcher) throws IOException {
       this.producer = producer;
     }
 
+    @Override
+    public void setMissingValue(Object missingValue) {
+      if (missingValue instanceof Number && getType() == Type.CUSTOM) {
+        this.missingValue = missingValue;
 
 Review comment:
   I think type will always be `Type.CUSTOM` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org