You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/11/07 22:18:39 UTC
Review Request 63648: Don't show host data when task is Throttled.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63648/
-----------------------------------------------------------
Review request for Aurora and Reza Motamedi.
Repository: aurora
Description
-------
PENDING and THROTTLED tasks are considered active and they dont have hosts. This manifests in having "null" host links.
Diffs
-----
ui/src/main/js/components/TaskDetails.js e3a6c9cb3838bcfe8bc3011944c1fff33d826b18
ui/src/main/js/components/__tests__/TaskDetails-test.js PRE-CREATION
Diff: https://reviews.apache.org/r/63648/diff/1/
Testing
-------
./gradlew ui:lint
./gradlew ui:test
Thanks,
David McLaughlin
Re: Review Request 63648: Don't show host data when task is Throttled.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63648/#review190377
-----------------------------------------------------------
Ship it!
Master (ad86177) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 7, 2017, 10:18 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63648/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 10:18 p.m.)
>
>
> Review request for Aurora and Reza Motamedi.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> PENDING and THROTTLED tasks are considered active and they dont have hosts. This manifests in having "null" host links.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskDetails.js e3a6c9cb3838bcfe8bc3011944c1fff33d826b18
> ui/src/main/js/components/__tests__/TaskDetails-test.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63648/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63648: Don't show host data when task is Throttled.
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63648/#review190380
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On Nov. 7, 2017, 10:18 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63648/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 10:18 p.m.)
>
>
> Review request for Aurora and Reza Motamedi.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> PENDING and THROTTLED tasks are considered active and they dont have hosts. This manifests in having "null" host links.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskDetails.js e3a6c9cb3838bcfe8bc3011944c1fff33d826b18
> ui/src/main/js/components/__tests__/TaskDetails-test.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63648/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>