You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/31 14:28:28 UTC
[GitHub] [flink] wuchong commented on a change in pull request #9275:
[FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not
compare row type field names and enable blink planner for hbase IT case
wuchong commented on a change in pull request #9275: [FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not compare row type field names and enable blink planner for hbase IT case
URL: https://github.com/apache/flink/pull/9275#discussion_r309251973
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java
##########
@@ -145,6 +156,14 @@ public static boolean isSingleFieldInterval(LogicalType logicalType) {
return logicalType.accept(SINGLE_FIELD_INTERVAL_EXTRACTOR);
}
+ public static boolean areTypeEqualsWithoutNames(LogicalType thisType, LogicalType thatType) {
Review comment:
What's the reason to use `hasEqualTypesWithoutNames`? It looks like whether it contains some equal types (might children types are equal).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services