You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2023/07/11 10:35:59 UTC

[GitHub] [kafka] yashmayya commented on pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

yashmayya commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1630582887

   Thanks @vamossagar12, I don't have any other comments other than the currently open ones - primarily the timeout case for when exactly-once support is enabled, the `ConnectorOffsetBackingStore::set` Javadoc, and the unit tests being in `OffsetStorageWriterTest` versus a dedicated `ConnectorOffsetBackingStoreTest` class (this one isn't blocking though). @C0urante could you please take a look at this whenever you get a chance? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org