[jira] [Commented] (METRON-1339) Stellar Shell: Should have a way to validate deployed functions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314083#comment-16314083 ] 

ASF GitHub Bot commented on METRON-1339:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/856#discussion_r159999157
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java ---
    @@ -0,0 +1,106 @@
    +/*
    + *
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + *
    + */
    +
    +package org.apache.metron.stellar.common.utils.validation;
    +
    +import static org.apache.metron.stellar.common.shell.StellarShell.ERROR_PROMPT;
    +
    +import java.lang.invoke.MethodHandles;
    +import java.util.ArrayList;
    +import java.util.HashSet;
    +import java.util.LinkedList;
    +import java.util.List;
    +import java.util.Optional;
    +import java.util.Set;
    +import org.apache.commons.lang.NullArgumentException;
    +import org.apache.curator.framework.CuratorFramework;
    +import org.apache.metron.stellar.common.StellarProcessor;
    +import org.atteo.classindex.ClassIndex;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class StellarZookeeperBasedValidator implements StellarValidator {
    +
    +  private static final Logger LOG = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
    +  private static final String FAILED_COMPILE = "Failed to compile";
    +  private CuratorFramework client;
    +
    +  public StellarZookeeperBasedValidator(CuratorFramework client) throws NullArgumentException {
    +    if (client == null) {
    +      throw new NullArgumentException("client");
    +    }
    +    this.client = client;
    +  }
    +
    +
    +  @Override
    +  public Iterable<ValidationResult> validate(Optional<LineWriter> writer) {
    +    // discover all the StellarConfigurationProvider
    +    Set<StellarConfigurationProvider> providerSet = new HashSet<>();
    +
    +    for (Class<?> c : ClassIndex.getSubclasses(StellarConfigurationProvider.class,
    --- End diff --
    
    I am not following your explanation of why we need the discovery logic.  Can you try to explain it again?  In the latest commits, I still see the discovery logic in StellarSimpleValidator.


> Stellar Shell: Should have a way to validate deployed functions
> ---------------------------------------------------------------
>
>                 Key: METRON-1339
>                 URL: https://issues.apache.org/jira/browse/METRON-1339
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>
> It is possible that the Stellar Language is changed during a release, meaning stellar expressions that are in zookeeper are now invalid, and will not run.
> Currently users cannot verify this without just letting them fail and hunting the errors down.
> The Stellar Shell should expose a '%' function that will verify that all stellar functions compile and are syntactically correct.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)