[GitHub] [camel-k] lburgazzoli commented on a change in pull request #717: Allow to provide custom settings.xml

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #717: Allow to provide custom settings.xml
URL: https://github.com/apache/camel-k/pull/717#discussion_r289383012
 
 

 ##########
 File path: pkg/cmd/install.go
 ##########
 @@ -62,8 +64,6 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) *cobra.Command {
 	cmd.Flags().StringVar(&impl.registry.Address, "registry", "", "A Docker registry that can be used to publish images")
 	cmd.Flags().StringVar(&impl.registry.Secret, "registry-secret", "", "A secret used to push/pull images to the Docker registry")
 	cmd.Flags().BoolVar(&impl.registry.Insecure, "registry-insecure", false, "Configure to configure registry access in insecure mode or not")
-	cmd.Flags().StringSliceVar(&impl.repositories, "repository", nil, "Add a maven repository")
-	cmd.Flags().BoolVar(&impl.snapshotRepositories, "snapshot-repositories", false, "Automatically include known snapshot repositories")
 	cmd.Flags().StringVar(&impl.localRepository, "local-repository", "", "Location of the local maven repository")
 
 Review comment:
   it is possible but then we need to provide our default settings.xml and eventually merge it with the one provided by the user

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services