[jira] [Commented] (AVRO-1247) Fix bug when using custom classloader

["Ben McCann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576234#comment-13576234 ] 

Ben McCann commented on AVRO-1247:
----------------------------------

awesome, thanks!
                
> Fix bug when using custom classloader
> -------------------------------------
>
>                 Key: AVRO-1247
>                 URL: https://issues.apache.org/jira/browse/AVRO-1247
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.3
>            Reporter: Ben McCann
>            Assignee: Doug Cutting
>              Labels: patch
>             Fix For: 1.7.4
>
>         Attachments: AVRO-1247.txt
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> I created a SpecificResponder with a SpecificData which contains my custom classloader (Play Framework's custom classloader actually). However, it's a real pain to do because SpecificResponder.getDatumReader and SpecificResponder.getDatumWriter don't use the SpecificData that I passed in. When creating a new object those two methods should use the SpecificData object that was passed in the constructor.
> {code:title=SpecificResponder.java}
>   @Override
>   protected DatumWriter<Object> getDatumWriter(Schema schema) {
>     // It currently uses SpecificData.INSTANCE which makes using a different ClassLoader very difficult
>     // return new SpecificDatumWriter<Object>(schema);
>     return new SpecificDatumWriter<Object>(schema, data);
>   }
>   @Override
>   protected DatumReader<Object> getDatumReader(Schema actual, Schema expected) {
>     // It currently uses SpecificData.INSTANCE which makes using a different ClassLoader very difficult
>     // return new SpecificDatumReader<Object>(actual, expected);
>     return new SpecificDatumReader<Object>(actual, expected, data);
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira