You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/08/27 14:35:54 UTC

Re: [PR] refactor: Unified the language for defining and addressing array elements.

Copilot commented on code in PR #2719:
URL: https://github.com/apache/plc4x/pull/2719#discussion_r3872754643


##########
plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/tag/FirmataTag.java:
##########
@@ -19,16 +19,20 @@
 package org.apache.plc4x.java.firmata.tag;
 
 import org.apache.plc4x.java.api.exceptions.PlcInvalidTagException;
+import org.apache.plc4x.java.api.model.ArrayInfo;
+import org.apache.plc4x.java.spi.drivers.model.AddressConstraints;
+import org.apache.plc4x.java.spi.drivers.model.ArrayNotationParser;
 import org.apache.plc4x.java.api.model.PlcTag;
 
 import java.util.Objects;
 import java.util.regex.Matcher;
+import java.util.regex.Matcher;

Review Comment:
   There is a duplicate `import java.util.regex.Matcher;`. This is redundant and may fail builds if the repo enforces checkstyle/spotless rules for unused/duplicate imports. Remove the duplicate import.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org