You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by ji...@apache.org on 2022/07/28 01:02:51 UTC

[rocketmq] branch develop updated: [ISSUE #4700]Optimize print information when the rocketmqHome variable not set (#4703)

This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new a58b2443a [ISSUE #4700]Optimize print information when the  rocketmqHome variable not set (#4703)
a58b2443a is described below

commit a58b2443a4d32e4a168caee5365bf59d73a50ca2
Author: mxsm <lj...@gmail.com>
AuthorDate: Thu Jul 28 09:02:41 2022 +0800

    [ISSUE #4700]Optimize print information when the  rocketmqHome variable not set (#4703)
---
 .../main/java/org/apache/rocketmq/controller/ControllerStartup.java | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java b/controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java
index 8c1ee89e0..a72c05a1b 100644
--- a/controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java
+++ b/controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java
@@ -29,6 +29,7 @@ import org.apache.commons.cli.CommandLine;
 import org.apache.commons.cli.Option;
 import org.apache.commons.cli.Options;
 import org.apache.commons.cli.PosixParser;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.rocketmq.common.MixAll;
 import org.apache.rocketmq.common.constant.LoggerName;
 import org.apache.rocketmq.common.ControllerConfig;
@@ -109,6 +110,11 @@ public class ControllerStartup {
         JoranConfigurator configurator = new JoranConfigurator();
         configurator.setContext(lc);
         lc.reset();
+
+        if (StringUtils.isEmpty(controllerConfig.getRocketmqHome())) {
+            System.out.printf("Please set the %s or %s variable in your environment!%n", MixAll.ROCKETMQ_HOME_ENV, MixAll.ROCKETMQ_HOME_PROPERTY);
+            System.exit(-1);
+        }
         configurator.doConfigure(controllerConfig.getRocketmqHome() + "/conf/logback_controller.xml");
 
         log = InternalLoggerFactory.getLogger(LoggerName.NAMESRV_LOGGER_NAME);