You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/25 14:18:59 UTC
[GitHub] [incubator-pinot] sunithabeeram commented on issue #4006:
Controller web cannot create and update schemas
sunithabeeram commented on issue #4006: Controller web cannot create and update schemas
URL: https://github.com/apache/incubator-pinot/pull/4006#issuecomment-476217198
A couple of general notes: please always add unit and integration tests to ensure:
a) Your code works as expected.
b) Your code is future proof-ed against refactors/regressions.
This section in the contribution guide expects manual testing done to be listed in the PR description:
https://pinot.readthedocs.io/en/latest/contribution_guidelines.html#creating-a-pull-request-pr
(I will update the contribution guide to include in the description the above 2 points I brought up as well)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org