[jira] [Commented] (FLINK-15386) SingleJobSubmittedJobGraphStore.putJobGraph has a logic error

["Ethan Li (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002910#comment-17002910 ] 

Ethan Li commented on FLINK-15386:
----------------------------------

I'd like to work on this if anyone can assign it to me. Thanks

> SingleJobSubmittedJobGraphStore.putJobGraph has a logic error
> -------------------------------------------------------------
>
>                 Key: FLINK-15386
>                 URL: https://issues.apache.org/jira/browse/FLINK-15386
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ethan Li
>            Priority: Minor
>
> https://github.com/apache/flink/blob/release-1.9/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/SingleJobSubmittedJobGraphStore.java#L61-L66
> {code:java}
> 	@Override
> 	public void putJobGraph(SubmittedJobGraph jobGraph) throws Exception {
> 		if (!jobGraph.getJobId().equals(jobGraph.getJobId())) { //this always returns false.
> 			throw new FlinkException("Cannot put additional jobs into this submitted job graph store.");
> 		}
> 	}
> {code}
> The code is there since 1.5 but fixed in the master branch (1.10). It's also better to add unit test for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)