You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/16 08:44:43 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9325: Remove DELETE /importErrors/{import_error_id} endpoint
mik-laj opened a new pull request #9325:
URL: https://github.com/apache/airflow/pull/9325
This table is managed by the scheduler. The user should not be able to influence its content.
Errors are removed by scheduler here:
https://github.com/apache/airflow/blob/master/airflow/utils/dag_processing.py#L862-L875
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9325: Remove DELETE /importErrors/{import_error_id} endpoint
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9325:
URL: https://github.com/apache/airflow/pull/9325#issuecomment-647100447
> @kaxil I think the problem should be fixed in Airflow and other systems should not base their integrations on Airflow bug. If we find a real use case, then we can add an endpoint, but the endpoint that has been added cannot be removed without beaking change.
>
> Generally, the API should provide the methods needed for the end user. No one should allow the modification of the internal state of the application. This is an internal state because in normal flow, we do not expect the user to make any modifications to this data. We can create a separate API that will allow for more operations, but it should not be marked as stable, because we will not be able to guarantee the stability of these API.
I would say this one should actually be a "feature not a bug". It is a "non-critical" operation. Anyways I don't have a strong enough opinion on this and if you do have, happy to approve it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9325: Remove DELETE /importErrors/{import_error_id} endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9325:
URL: https://github.com/apache/airflow/pull/9325#issuecomment-647097821
@kaxil I think the problem should be fixed in Airflow and other systems should not base their integrations on Airflow bug. If we find a real use case, then we can add an endpoint, but the endpoint that has been added cannot be removed without beaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #9325: Remove DELETE /importErrors/{import_error_id} endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #9325:
URL: https://github.com/apache/airflow/pull/9325#issuecomment-647097821
@kaxil I think the problem should be fixed in Airflow and other systems should not base their integrations on Airflow bug. If we find a real use case, then we can add an endpoint, but the endpoint that has been added cannot be removed without beaking change.
Generally, the API should provide the methods needed for the end user. No one should allow the modification of the internal state of the application. This is an internal state because in normal flow, we do not expect the user to make any modifications to this data. We can create a separate API that will allow for more operations, but it should not be marked as stable, because we will not be able to guarantee the stability of these API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9325: Remove DELETE /importErrors/{import_error_id} endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9325:
URL: https://github.com/apache/airflow/pull/9325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org