[GitHub] [accumulo] ctubbsii commented on a change in pull request #2496: Modify ZooKeeperTestingServer to use Junit TemporaryFolder

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2496:
URL: https://github.com/apache/accumulo/pull/2496#discussion_r806335817



##########
File path: test/src/main/java/org/apache/accumulo/test/zookeeper/ZooKeeperTestingServer.java
##########
@@ -47,15 +47,15 @@
    * Instantiate a running zookeeper server - this call will block until the server is ready for
    * client connections. It will try three times, with a 5 second pause to connect.
    */
-  public ZooKeeperTestingServer() {
-    this(PortUtils.getRandomFreePort());
+  public ZooKeeperTestingServer(TemporaryFolder tmpDir) {

Review comment:
       This should not accept the TemporaryFolder type, because that is a JUnit specific Rule type. It should instead accept a normal `File` directory, and `TEMP.newFolder()` be called prior to constructing this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org