You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "Stephan Erb (JIRA)" <ji...@apache.org> on 2017/04/03 22:10:41 UTC

[jira] [Commented] (AURORA-1707) Remove deprecated resource fields in TaskConfig and ResourceAggregate

    [ https://issues.apache.org/jira/browse/AURORA-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954231#comment-15954231 ] 

Stephan Erb commented on AURORA-1707:
-------------------------------------

Additional patch towards deprecation:

{code}
commit 72046170ddfa046bc0c842fbeb9ecf797e569717
Author: Nicolás Donatucci <nd...@medallia.com>
Date:   Tue Apr 4 00:00:14 2017 +0200

    Remove use of deprecated fields in tests

    Removed the usage of numCpus, ramMb and diskMb from tests and replaced them with
    the Resource set when necessary. Also modified the thrift backfill so that it won't
    backfill those resource fields anymore.

    Related Issue: Aurora-1707

    Reviewed at https://reviews.apache.org/r/57881/

 src/jmh/java/org/apache/aurora/benchmark/Tasks.java                                   |   6 +-----
 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java     |   4 ----
 src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java             |  22 ----------------------
 src/main/python/apache/aurora/config/thrift.py                                        |  17 ++++++++---------
 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java |   4 ----
 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java   |  10 +++++++---
 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java        |   3 ---
 src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java                |   5 ++++-
 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java   |  27 ++++++++++++++++++++++-----
 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java             |   4 ----
 src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java             |   3 +--
 src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java              |  10 +++++++---
 src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java        |  11 ++++++++---
 src/test/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollectorTest.java     |   7 ++++++-
 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java             |   6 +++---
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java        |  13 +------------
 src/test/java/org/apache/aurora/scheduler/storage/log/ThriftBackfillTest.java         | 106 ++++++++++++++++++----------------------------------------------------------------------------------------
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java       |  19 +++++++++++++++----
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java    |  78 ++++++++++++++++++++++++------------------------------------------------------
 src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java            |   8 ++++++--
 src/test/python/apache/aurora/config/test_base.py                                     |  25 +++++++++++++++++--------
 src/test/python/apache/aurora/config/test_thrift.py                                   |   7 ++-----
 22 files changed, 150 insertions(+), 245 deletions(-)
{code}

> Remove deprecated resource fields in TaskConfig and ResourceAggregate
> ---------------------------------------------------------------------
>
>                 Key: AURORA-1707
>                 URL: https://issues.apache.org/jira/browse/AURORA-1707
>             Project: Aurora
>          Issue Type: Task
>            Reporter: Maxim Khutornenko
>            Assignee: Nicolas Donatucci
>
> Remove individual resource fields in TaskConfig and ResourceAggregate replaced by the new {{Resource}} struct.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)