You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/05/14 01:10:44 UTC

[PR] HDDS-15264. Fork RetryInvocationHandler from Hadoop [ozone]

adoroszlai opened a new pull request, #10263:
URL: https://github.com/apache/ozone/pull/10263

   ## What changes were proposed in this pull request?
   
   Hadoop `RetryInvocationHandler` is coupled with RPC implementation.  It references code in `org.apache.hadoop.ipc` and most importantly, keeps state in `Client`'s static variables.  Thus it should be forked, too, along with dependent classes.
   
   This PR:
   - copies code from Hadoop as is from 3.2.4
   - backports some minor changes from 3.4.3
   - changes package name to `org.apache.hadoop.io_.retry`
   - removes Hadoop-specific `InterfaceAudience`/`InterfaceStability`
   - removes `VisibleForTesting` and unused code
   - changes existing Ozone code to use the forked classes
   
   https://issues.apache.org/jira/browse/HDDS-15264
   
   ## How was this patch tested?
   
   https://github.com/adoroszlai/ozone/actions/runs/25825251785
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-15264. Fork RetryInvocationHandler from Hadoop [ozone]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #10263:
URL: https://github.com/apache/ozone/pull/10263#issuecomment-4467878426

   > I get "Not Found" when trying to open these.
   
   @adoroszlai , When I click the link, it will download the files even without signed it:
   <img width="730" height="528" alt="image" src="https://github.com/user-attachments/assets/fb917389-a7fa-4a4e-b0dd-abaa4a769282" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-15264. Fork RetryInvocationHandler from Hadoop [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #10263:
URL: https://github.com/apache/ozone/pull/10263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-15264. Fork RetryInvocationHandler from Hadoop [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #10263:
URL: https://github.com/apache/ozone/pull/10263#issuecomment-4467890000

   > > I get "Not Found" when trying to open these.
   > 
   > When I click the link, it will download the files
   
   Thanks, now it works for me, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-15264. Fork RetryInvocationHandler from Hadoop [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #10263:
URL: https://github.com/apache/ozone/pull/10263#issuecomment-4467664070

   Thanks @szetszwo for the review.
   
   > Verify the diff between the files in Hadoop and the files in this PR.
   > 
   > * [RetryProxy.java.patch](https://github.com/user-attachments/files/27858229/RetryProxy.java.patch)
   > * [RetryInvocationHandler.java.patch](https://github.com/user-attachments/files/27858230/RetryInvocationHandler.java.patch)
   > * [CallReturn.java.patch](https://github.com/user-attachments/files/27858231/CallReturn.java.patch)
   > * [AsyncCallHandler.java.patch](https://github.com/user-attachments/files/27858232/AsyncCallHandler.java.patch)
   
   I get "Not Found" when trying to open these.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org