[GitHub] rhtyd commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225119494
 
 

 ##########
 File path: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##########
 @@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId, final Account callerAccount,
         s_logger.debug("Implementing the network " + network + " elements and resources as a part of network restart without cleanup");
         try {
             implementNetworkElementsAndResources(dest, context, network, offering);
-            setRestartRequired(network, true);
+            setRestartRequired(network, false);
 
 Review comment:
   This fixes an issue where restarting a network without cleanup always put the network's restart required flag to true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services