[GitHub] [superset] CodeingBoy commented on a change in pull request #17816: fix(time_picker): Fix incorrect time range display

[GitBox <gi...@apache.org>]

CodeingBoy commented on a change in pull request #17816:
URL: https://github.com/apache/superset/pull/17816#discussion_r773553743



##########
File path: superset-frontend/src/explore/constants.ts
##########
@@ -136,4 +136,9 @@ export const TIME_FILTER_MAP = {
 
 // TODO: make this configurable per Superset installation
 export const DEFAULT_TIME_RANGE = 'No filter';
+// Default time range endpoints [start, end)
+export const DEFAULT_TIME_RANGE_ENDPOINTS: TimeRangeEndpoints = [

Review comment:
       This is fixed by SIP-15 #6360, are you sure want to provide an option allowing user customizing it? Besides, maybe we should create another issues, providing this as new feature instead of part of bugfix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org