[GitHub] [tvm] stoa commented on a change in pull request #9363: STM32 performance and validation apps examples

[GitBox <gi...@apache.org>]

stoa commented on a change in pull request #9363:
URL: https://github.com/apache/tvm/pull/9363#discussion_r747494931



##########
File path: apps/microtvm/stm32/Src/Validation/pb_decode.c
##########
@@ -0,0 +1,1528 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file pb_decode.c
+ * \brief decode a protobuf using minimal resources.
+ *        2011 Petteri Aimonen <jp...@kapsi.fi>
+ */

Review comment:
       Clear. Will it be OK to create an apps-stm32 sub-directory inside the 3rdparty directory that will contain the 5 files that we are talking about ? Checking in the nanopb looks too heavy for the use we make, additionally I would not know where to put the 2 files generated via the nanopb for our target. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org