You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/20 18:15:26 UTC
[GitHub] [camel-quarkus] ffang opened a new pull request #3024: fix SolrTest failure when using CloundContainer #2967
ffang opened a new pull request #3024:
URL: https://github.com/apache/camel-quarkus/pull/3024
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on pull request #3024: fix SolrTest failure when using CloundContainer #2967
Posted by GitBox <gi...@apache.org>.
ffang commented on pull request #3024:
URL: https://github.com/apache/camel-quarkus/pull/3024#issuecomment-906768601
> @ffang could you please amend and force push to your feature branch rather than add a new commit next time you address the review feedback? Most of us prefer once commit per issue fix so that the history is easier to read and so that fixes are easier backport to maintenance branches.
Sure @ppalaga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3024: fix SolrTest failure when using CloundContainer #2967
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3024:
URL: https://github.com/apache/camel-quarkus/pull/3024#discussion_r694702439
##########
File path: integration-tests/solr/src/test/java/org/apache/camel/quarkus/component/solr/it/SolrTestResource.java
##########
@@ -111,10 +112,17 @@ private void createSslContainer() {
* creates a cloud container with zookeeper
*/
private void createCloudContainer() {
- cloudContainer = new DockerComposeContainer(new File("src/test/resources/cloud-docker-compose.yml"))
- .withExposedService("solr1", SOLR_PORT)
- .withExposedService("zoo1", ZOOKEEPER_PORT)
- .waitingFor("create-collection", Wait.forLogMessage(".*Created collection 'collection1'.*", 1));
+ if (SystemUtils.IS_OS_LINUX) {
+ cloudContainer = new DockerComposeContainer(new File("src/test/resources/cloud-docker-compose.yml"))
Review comment:
Can these be read from the classpath? I'm not sure resolving from the source tree will work on the `quarkus-platform` build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on a change in pull request #3024: fix SolrTest failure when using CloundContainer #2967
Posted by GitBox <gi...@apache.org>.
ffang commented on a change in pull request #3024:
URL: https://github.com/apache/camel-quarkus/pull/3024#discussion_r694868012
##########
File path: integration-tests/solr/src/test/java/org/apache/camel/quarkus/component/solr/it/SolrTestResource.java
##########
@@ -111,10 +112,17 @@ private void createSslContainer() {
* creates a cloud container with zookeeper
*/
private void createCloudContainer() {
- cloudContainer = new DockerComposeContainer(new File("src/test/resources/cloud-docker-compose.yml"))
- .withExposedService("solr1", SOLR_PORT)
- .withExposedService("zoo1", ZOOKEEPER_PORT)
- .waitingFor("create-collection", Wait.forLogMessage(".*Created collection 'collection1'.*", 1));
+ if (SystemUtils.IS_OS_LINUX) {
+ cloudContainer = new DockerComposeContainer(new File("src/test/resources/cloud-docker-compose.yml"))
Review comment:
@jamesnetherton , pushed a new commit, please take a look.
Thanks!
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #3024: fix SolrTest failure when using CloundContainer #2967
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #3024:
URL: https://github.com/apache/camel-quarkus/pull/3024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org