You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by oxygen311 <gi...@git.apache.org> on 2018/07/24 13:47:20 UTC
[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...
GitHub user oxygen311 opened a pull request:
https://github.com/apache/zeppelin/pull/3093
[ZEPPELIN-3655] Add missing roles information to /notebook/api method
### What is this PR for?
Fix bugs with private access interpreter launched with REST by adding missing roles information to `AuthenticationInfo`.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3655
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3093
----
commit 182dadcbd3dd000e8d01fc33fe8f0d152fd3450c
Author: oxygen311 <al...@...>
Date: 2018-07-24T13:40:38Z
Fix roles info
----
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3093
Can you add unit test ?
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3093
It's don't easy to check this bug with a unit test. Even in Paragraph is not running because of "user has no permission for interpreter" response in rest api would be "OK"
---
[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 closed the pull request at:
https://github.com/apache/zeppelin/pull/3093
---
[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...
Posted by oxygen311 <gi...@git.apache.org>.
GitHub user oxygen311 reopened a pull request:
https://github.com/apache/zeppelin/pull/3093
[ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method
### What is this PR for?
Fix bugs with private access interpreter launched with REST by adding missing roles information to `AuthenticationInfo`.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3655
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3093
----
commit 182dadcbd3dd000e8d01fc33fe8f0d152fd3450c
Author: oxygen311 <al...@...>
Date: 2018-07-24T13:40:38Z
Fix roles info
commit 04442840e84329981e5a115679e3511a5e96319c
Author: oxygen311 <al...@...>
Date: 2018-07-26T08:54:08Z
Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-3655
# Conflicts:
# zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
commit 407b1041b53d2f7ccaa814dd049a55ed95b0c354
Author: oxygen311 <al...@...>
Date: 2018-07-26T08:54:28Z
Change
commit aa51ca36814f8ab6e8fba169a95062e4e1916877
Author: oxygen311 <al...@...>
Date: 2018-07-26T11:16:23Z
Add roles info to run paragraph method
----
---
[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 closed the pull request at:
https://github.com/apache/zeppelin/pull/3093
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3093
@zjffdu
Also this bug may occur in run paragraph methods, it's also fixed now.
Other methods don't miss role info because they don't need to pass it farther. And `checkIfUserCanWrite` and `checkIfUserCanWrite` which is used in most rest api calls are take into roles information.
---
[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3093
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3093
@oxygen311 Could you resolve conflict ?
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3093
Thanks @oxygen311 LGTM
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3093
It looks like all the public api in NotebookRestApi miss the role info. Do you see any issue when roles is missing ? I think it is better to set roles properly in some kind of Filter.
---
[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3093
@zjffdu done
---
[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...
Posted by oxygen311 <gi...@git.apache.org>.
GitHub user oxygen311 reopened a pull request:
https://github.com/apache/zeppelin/pull/3093
[ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method
### What is this PR for?
Fix bugs with private access interpreter launched with REST by adding missing roles information to `AuthenticationInfo`.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3655
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3093
----
commit 182dadcbd3dd000e8d01fc33fe8f0d152fd3450c
Author: oxygen311 <al...@...>
Date: 2018-07-24T13:40:38Z
Fix roles info
----
---