You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/01 01:26:51 UTC

[GitHub] [arrow] kou opened a new pull request, #13039: ARROW-16428: [Release] Add prefix to ENV variables

kou opened a new pull request, #13039:
URL: https://github.com/apache/arrow/pull/13039

   We should not use ENV as variable name because it's used for sh:
   
   dash(1):
   
   > If the environment variable ENV is set on entry to an interactive
   > shell, or is set in the .profile of a login shell, the shell next
   > reads commands from the file named in ENV.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13039:
URL: https://github.com/apache/arrow/pull/13039#issuecomment-1114095683

   https://issues.apache.org/jira/browse/ARROW-16428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13039:
URL: https://github.com/apache/arrow/pull/13039#issuecomment-1119073262

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3cb5c9a217ce43e3a580a511ac928b20...aa239ba8349449d7a51c8b86a14bea67/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13039:
URL: https://github.com/apache/arrow/pull/13039#issuecomment-1119073051

   Benchmark runs are scheduled for baseline = f8d6eac3d97876eed43faa9aaec9f1201dec55ba and contender = 9010c8e6e8034a708533d9aba307152eef5969b1. 9010c8e6e8034a708533d9aba307152eef5969b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff1b8cdce40c4269bd7b9bc7af761876...4578ef7dd3e34b3db30d3184ab705043/)
   [Failed :arrow_down:0.47% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4cadbee0f5d94ba694eda41f4440c573...defbc9813cb84688b6f8128ae555ae25/)
   [Finished :arrow_down:5.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3cb5c9a217ce43e3a580a511ac928b20...aa239ba8349449d7a51c8b86a14bea67/)
   [Finished :arrow_down:0.24% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b1e8dfa00170401ba7fb2205182fc27c...1b0570ab72f54c879a3bb66bcfee2bff/)
   Buildkite builds:
   [Finished] [`9010c8e6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/675)
   [Failed] [`9010c8e6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/672)
   [Finished] [`9010c8e6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/661)
   [Finished] [`9010c8e6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/677)
   [Finished] [`f8d6eac3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/674)
   [Finished] [`f8d6eac3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/671)
   [Finished] [`f8d6eac3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/660)
   [Finished] [`f8d6eac3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/676)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a diff in pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13039:
URL: https://github.com/apache/arrow/pull/13039#discussion_r864617431


##########
dev/release/verify-release-candidate.sh:
##########
@@ -982,8 +982,8 @@ test_linux_wheels() {
     local pyver=${python/m}
     for platform in ${platform_tags}; do
       show_header "Testing Python ${pyver} wheel for platform ${platform}"
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv || continue
+      VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1

Review Comment:
   Here is the fix https://github.com/apache/arrow/pull/13061



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a diff in pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #13039:
URL: https://github.com/apache/arrow/pull/13039#discussion_r865381255


##########
dev/release/verify-release-candidate.sh:
##########
@@ -982,8 +982,8 @@ test_linux_wheels() {
     local pyver=${python/m}
     for platform in ${platform_tags}; do
       show_header "Testing Python ${pyver} wheel for platform ${platform}"
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv || continue
+      VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1

Review Comment:
   Oh, sorry...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
kou closed pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables
URL: https://github.com/apache/arrow/pull/13039


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on a diff in pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13039:
URL: https://github.com/apache/arrow/pull/13039#discussion_r864342770


##########
dev/release/verify-release-candidate.sh:
##########
@@ -982,8 +982,8 @@ test_linux_wheels() {
     local pyver=${python/m}
     for platform in ${platform_tags}; do
       show_header "Testing Python ${pyver} wheel for platform ${platform}"
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv || continue
+      VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1

Review Comment:
   Should this be CONDA_ENV here and on L1016 below? I was having trouble verifying wheels until I changed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a diff in pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13039:
URL: https://github.com/apache/arrow/pull/13039#discussion_r864609408


##########
dev/release/verify-release-candidate.sh:
##########
@@ -982,8 +982,8 @@ test_linux_wheels() {
     local pyver=${python/m}
     for platform in ${platform_tags}; do
       show_header "Testing Python ${pyver} wheel for platform ${platform}"
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv || continue
+      VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1

Review Comment:
   It should, putting up a PR. Thanks for catching that!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org