[GitHub] [maven-verifier] adekzs commented on a diff in pull request #55: Deprecate multivariant constructors for removal

[GitBox <gi...@apache.org>]

adekzs commented on code in PR #55:
URL: https://github.com/apache/maven-verifier/pull/55#discussion_r985238864


##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -115,61 +115,157 @@
 
     private static MavenLauncher embeddedLauncher;
 
+    private String settingsFile;
+
+    private boolean debug;
+
     public Verifier( String basedir )
         throws VerificationException
     {
-        this( basedir, null );
+        this.basedir = basedir;
+
+        this.forkMode = System.getProperty( "verifier.forkMode" );
+
+        findLocalRepo( settingsFile );
+
+        this.mavenHome = System.getProperty( "maven.home" );
+
+        useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
+
+        this.defaultCliArguments = DEFAULT_CLI_ARGUMENTS.clone();
+
     }
 
+    /**
+    *
+    * @deprecated to be removed
+    * use {@link #Verifier(String basedir)}
+     *
+    * */
+    @Deprecated
     public Verifier( String basedir, boolean debug )
         throws VerificationException
     {
         this( basedir, null, debug );

Review Comment:
   Okay, I get your point. I will update accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org