You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/09/15 13:45:13 UTC
[Impala-ASF-CR] Generate test-classpath.txt
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16450
Change subject: Generate test-classpath.txt
......................................................................
Generate test-classpath.txt
Currently the hive-jdbc jar is added under the scope 'test'.
Therefore it won't be included in the build-classpath.txt because it
only includes jars from the 'runtime' scope. Because of this
run-hive-jdbc.sh throws ClassNotFoundException exception.
This commit adds a new execution 'write-test-classpath' to pom.xml.
It creates a test-classpath.txt. This can be used by scripts that need
classes from the 'test' scope.
Modified set-classpath.sh as well. If its first argument is 'test',
then it also adds the contents of test-classpath.txt to the CLASSPATH.
Now run-jdbc-client.sh sources 'set-classpath.sh test'.
Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
---
M bin/run-jdbc-client.sh
M bin/set-classpath.sh
M fe/pom.xml
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16450/1
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7181/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2020 14:06:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7199/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:44:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16450
to look at the new patch set (#6).
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
IMPALA-10177: Generate test-classpath.txt
Currently the hive-jdbc jar is added under the scope 'test'.
Therefore it won't be included in the build-classpath.txt because it
only includes jars from the 'runtime' scope. Therefore
run-hive-jdbc.sh throws ClassNotFoundException exception.
This commit adds a new execution 'write-test-classpath' to pom.xml.
It creates a test-classpath.txt. This can be used by scripts that need
classes from the 'test' scope.
Modified set-classpath.sh as well. If its first argument is 'test',
then it also adds the contents of test-classpath.txt to the CLASSPATH.
Now run-jdbc-client.sh sources 'set-classpath.sh test'.
Testing:
* executed core tests, turned out test_describe_formatted is broken,
see IMPALA-10176 for details. Disabling that test for now.
Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
---
M bin/run-jdbc-client.sh
M bin/set-classpath.sh
M fe/pom.xml
M tests/metadata/test_metadata_query_statements.py
4 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16450/6
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6445/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:46:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6437/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2020 09:46:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 15:25:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6445/
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:03:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7196/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:33:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 16:46:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2020 09:46:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7208/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 14:40:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16450
to look at the new patch set (#5).
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
IMPALA-10177: Generate test-classpath.txt
Currently the hive-jdbc jar is added under the scope 'test'.
Therefore it won't be included in the build-classpath.txt because it
only includes jars from the 'runtime' scope. Therefore
run-hive-jdbc.sh throws ClassNotFoundException exception.
This commit adds a new execution 'write-test-classpath' to pom.xml.
It creates a test-classpath.txt. This can be used by scripts that need
classes from the 'test' scope.
Modified set-classpath.sh as well. If its first argument is 'test',
then it also adds the contents of test-classpath.txt to the CLASSPATH.
Now run-jdbc-client.sh sources 'set-classpath.sh test'.
Testing:
* executed core tests, turned out test_describe_formatted is broken,
see IMPALA-10176 for details. Disabling that test for now.
Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
---
M bin/run-jdbc-client.sh
M bin/set-classpath.sh
M fe/pom.xml
M tests/metadata/test_metadata_query_statements.py
4 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16450/5
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Patch Set 3:
The pre-commit job failed because without this fix test_describe_formatted was broken, i.e. it compared two empty result sets.
I disabled test_describe_formatted and opened IMPALA-10176 for it.
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:12:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6453/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 15:25:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16450
to look at the new patch set (#3).
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
IMPALA-10177: Generate test-classpath.txt
Currently the hive-jdbc jar is added under the scope 'test'.
Therefore it won't be included in the build-classpath.txt because it
only includes jars from the 'runtime' scope. Because of this
run-hive-jdbc.sh throws ClassNotFoundException exception.
This commit adds a new execution 'write-test-classpath' to pom.xml.
It creates a test-classpath.txt. This can be used by scripts that need
classes from the 'test' scope.
Modified set-classpath.sh as well. If its first argument is 'test',
then it also adds the contents of test-classpath.txt to the CLASSPATH.
Now run-jdbc-client.sh sources 'set-classpath.sh test'.
Testing:
* executed core tests, turned out test_describe_formatted is broken,
see IMPALA-10176 for details. Disabling that test for now.
Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
---
M bin/run-jdbc-client.sh
M bin/set-classpath.sh
M fe/pom.xml
M tests/metadata/test_metadata_query_statements.py
4 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16450/3
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
IMPALA-10177: Generate test-classpath.txt
Currently the hive-jdbc jar is added under the scope 'test'.
Therefore it won't be included in the build-classpath.txt because it
only includes jars from the 'runtime' scope. Therefore
run-hive-jdbc.sh throws ClassNotFoundException exception.
This commit adds a new execution 'write-test-classpath' to pom.xml.
It creates a test-classpath.txt. This can be used by scripts that need
classes from the 'test' scope.
Modified set-classpath.sh as well. If its first argument is 'test',
then it also adds the contents of test-classpath.txt to the CLASSPATH.
Now run-jdbc-client.sh sources 'set-classpath.sh test'.
Testing:
* executed core tests, turned out test_describe_formatted is broken,
see IMPALA-10176 for details. Disabling that test for now.
Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Reviewed-on: http://gerrit.cloudera.org:8080/16450
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-jdbc-client.sh
M bin/set-classpath.sh
M fe/pom.xml
M tests/metadata/test_metadata_query_statements.py
4 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6437/
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2020 15:14:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 20:46:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7195/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:30:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10177: Generate test-classpath.txt
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: IMPALA-10177: Generate test-classpath.txt
......................................................................
Patch Set 6: Code-Review+2
Did a minor fix for the case when set-classpath.sh was executed with "set -u" (treat unset variables as an error).
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 15:24:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has uploaded a new patch set (#4) to the change originally created by Zoltan Borok-Nagy. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Generate test-classpath.txt
Currently the hive-jdbc jar is added under the scope 'test'.
Therefore it won't be included in the build-classpath.txt because it
only includes jars from the 'runtime' scope. Because of this
run-hive-jdbc.sh throws ClassNotFoundException exception.
This commit adds a new execution 'write-test-classpath' to pom.xml.
It creates a test-classpath.txt. This can be used by scripts that need
classes from the 'test' scope.
Modified set-classpath.sh as well. If its first argument is 'test',
then it also adds the contents of test-classpath.txt to the CLASSPATH.
Now run-jdbc-client.sh sources 'set-classpath.sh test'.
Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
---
M bin/run-jdbc-client.sh
M bin/set-classpath.sh
M fe/pom.xml
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16450/4
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Generate test-classpath.txt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16450 )
Change subject: Generate test-classpath.txt
......................................................................
Patch Set 1: Code-Review+2
This makes sense to me. Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/16450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e4340fde9a5678d94459f676d8894dc5da14dc
Gerrit-Change-Number: 16450
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2020 00:56:44 +0000
Gerrit-HasComments: No