You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2014/04/21 05:05:37 UTC
svn commit: r1588847 - in /lucene/dev/branches/branch_4x: ./ solr/
solr/test-framework/
solr/test-framework/src/java/org/apache/solr/cloud/StopableIndexingThread.java
Author: markrmiller
Date: Mon Apr 21 03:05:36 2014
New Revision: 1588847
URL: http://svn.apache.org/r1588847
Log:
SOLR-5996: Improve request fail logging by including id.
Modified:
lucene/dev/branches/branch_4x/ (props changed)
lucene/dev/branches/branch_4x/solr/ (props changed)
lucene/dev/branches/branch_4x/solr/test-framework/ (props changed)
lucene/dev/branches/branch_4x/solr/test-framework/src/java/org/apache/solr/cloud/StopableIndexingThread.java
Modified: lucene/dev/branches/branch_4x/solr/test-framework/src/java/org/apache/solr/cloud/StopableIndexingThread.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/test-framework/src/java/org/apache/solr/cloud/StopableIndexingThread.java?rev=1588847&r1=1588846&r2=1588847&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/solr/test-framework/src/java/org/apache/solr/cloud/StopableIndexingThread.java (original)
+++ lucene/dev/branches/branch_4x/solr/test-framework/src/java/org/apache/solr/cloud/StopableIndexingThread.java Mon Apr 21 03:05:36 2014
@@ -76,22 +76,22 @@ public class StopableIndexingThread exte
boolean addFailed = false;
if (doDeletes && AbstractFullDistribZkTestBase.random().nextBoolean() && deletes.size() > 0) {
- String delete = deletes.remove(0);
+ String deleteId = deletes.remove(0);
try {
numDeletes++;
if (controlClient != null) {
UpdateRequest req = new UpdateRequest();
- req.deleteById(delete);
+ req.deleteById(deleteId);
req.setParam("CONTROL", "TRUE");
req.process(controlClient);
}
- cloudClient.deleteById(delete);
+ cloudClient.deleteById(deleteId);
} catch (Exception e) {
- System.err.println("REQUEST FAILED:");
+ System.err.println("REQUEST FAILED for id=" + deleteId);
e.printStackTrace();
if (e instanceof SolrServerException) {
- System.err.println("ROOT CAUSE:");
+ System.err.println("ROOT CAUSE for id=" + deleteId);
((SolrServerException) e).getRootCause().printStackTrace();
}
deleteFails.add(id);
@@ -104,10 +104,10 @@ public class StopableIndexingThread exte
"to come to the aid of their country.");
} catch (Exception e) {
addFailed = true;
- System.err.println("REQUEST FAILED:");
+ System.err.println("REQUEST FAILED for id=" + id);
e.printStackTrace();
if (e instanceof SolrServerException) {
- System.err.println("ROOT CAUSE:");
+ System.err.println("ROOT CAUSE for id=" + id);
((SolrServerException) e).getRootCause().printStackTrace();
}
addFails.add(id);