You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2026/09/15 11:07:16 UTC
[Bug 8418] New: rules/25_url_shortener.cf is wrong after the plugin merge
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
Bug ID: 8418
Summary: rules/25_url_shortener.cf is wrong after the plugin
merge
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: sidney@sidney.com
Target Milestone: Undefined
Now that DecodeShortURLs has been merged into Redirectors
rules/25_url_shortener.cf no longer loads properly. It has lines
if can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir)
and
if !can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir)
I was going to say they have to be changed to use Redirectors:: and that's what
I tested with successfully against trunk, but I realized that could break
someone who runs sa-update who is not running latest trunk.
Is that correct, or does sa-update get different files for 4.0.x and trunk?
Should those limes be changed for backwards compatibility to
if can(Mail::SpamAssassin::Plugin::Redirectors::has_short_url_redir) ||
can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir)
and
if !(can(Mail::SpamAssassin::Plugin::Redirectors::has_short_url_redir) ||
can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir))
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8418] rules/25_url_shortener.cf is wrong after the plugin merge
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Giovanni Bechis <gi...@paclan.it> ---
Sending lib/Mail/SpamAssassin/Conf/Parser.pm
Transmitting file data .done
Committing transaction...
Committed revision 1938356.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8418] rules/25_url_shortener.cf is wrong after the plugin merge
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |4.0.3
CC| |sidney@sidney.com
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8418] rules/25_url_shortener.cf is wrong after the plugin merge
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 6084
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=6084&action=edit
Proposed patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8418] rules/25_url_shortener.cf is wrong after the plugin merge
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
Bill Cole <bi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |billcole@apache.org
--- Comment #4 from Bill Cole <bi...@apache.org> ---
+1 to patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8418] rules/25_url_shortener.cf is wrong after the plugin merge
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
--- Comment #3 from Sidney Markowitz <si...@sidney.com> ---
That patch fixes my test cases
+1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8418] rules/25_url_shortener.cf is wrong after the plugin merge
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #1 from Giovanni Bechis <gi...@paclan.it> ---
Commit r1937762 made `ifplugin` work to have compatibility with current rules,
we should support `can` as well.
--
You are receiving this mail because:
You are the assignee for the bug.