You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/06/03 06:22:25 UTC

Re: Review Request 70715: Added method `empty()` for `ResourceLimits`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70715/#review215640
-----------------------------------------------------------



Bad review!

Reviews applied: [70715, 70714, 70713, 70707, 70750]

Error:
2019-06-03 06:22:24 URL:https://reviews.apache.org/r/70715/diff/raw/ [601/601] -> "70715.patch" [1]
error: patch failed: src/common/resource_quantities.hpp:226
error: src/common/resource_quantities.hpp: patch does not apply

- Mesos Reviewbot


On May 24, 2019, 8 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70715/
> -----------------------------------------------------------
> 
> (Updated May 24, 2019, 8 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added method `empty()` for `ResourceLimits`.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp bc5b96df366f2e077e17a4dead7fdb87bc65f2df 
> 
> 
> Diff: https://reviews.apache.org/r/70715/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>