[GitHub] [solr] uschindler commented on pull request #1320: SOLR-16641 - Generate gradle.properties from gradlew

["uschindler (via GitHub)" <gi...@apache.org>]

uschindler commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411867969

   > The check on crave.io is failing to apply my commit... I'm guessing that's because I've been force pushing to my branch and it's now a bit out of sync? https://github.com/apache/solr/actions/runs/4063490165/jobs/6995782967
   > 
   > ```
   > error: patch failed: gradlew.bat:80
   > error: gradlew.bat: patch does not apply
   > hint: Use 'git am --show-current-patch=diff' to see the failed patch
   > Applying: SOLR-16632: Add core name to periodic delete related log messages (#1311)
   > Applying: SOLR-16641 - Generate gradle.properties from template
   > Patch failed at 0002 SOLR-16641 - Generate gradle.properties from template
   > When you have resolved this problem, run "git am --continue".
   > If you prefer to skip this patch, run "git am --skip" instead.
   > To restore the original branch and stop patching, run "git am --abort".
   > ```
   > 
   > I can create a clean PR on a fresh branch to test that, unless there's another reason for it to happen?
   
   Don't force-push in PRs :-)
   
   PRs are anyways squash merged, so no need to squash them before. It also makes it hard to review when you do changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org