You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Omega359 (via GitHub)" <gi...@apache.org> on 2024/11/14 02:43:58 UTC
[PR] Add support for Utf8View to crypto functions [datafusion]
Omega359 opened a new pull request, #13407:
URL: https://github.com/apache/datafusion/pull/13407
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #13406
## Rationale for this change
Completing support for utf8view in functions.
## What changes are included in this PR?
Code, tests.
## Are these changes tested?
Yes
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add support for Utf8View to crypto functions [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #13407:
URL: https://github.com/apache/datafusion/pull/13407#issuecomment-2479812462
I tried to write some more tests for this code and I think it may have introduced a bug. See
- in https://github.com/apache/datafusion/pull/13443
- https://github.com/apache/datafusion/issues/13444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add support for Utf8View to crypto functions [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #13407:
URL: https://github.com/apache/datafusion/pull/13407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add support for Utf8View to crypto functions [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #13407:
URL: https://github.com/apache/datafusion/pull/13407#issuecomment-2479798948
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add support for Utf8View to crypto functions [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #13407:
URL: https://github.com/apache/datafusion/pull/13407#issuecomment-2479816395
I'll take a look at this tonight if no one else beats me to it
On Fri, Nov 15, 2024, 2:50 p.m. Andrew Lamb ***@***.***>
wrote:
> I tried to write some more tests for this code and I think it may have
> introduced a bug. See
>
> - in #13443 <https://github.com/apache/datafusion/pull/13443>
> - #13444 <https://github.com/apache/datafusion/issues/13444>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/datafusion/pull/13407#issuecomment-2479812462>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABXHUQMSQVHLAMXBSMYSZ32AZGB3AVCNFSM6AAAAABRX3SQFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZZHAYTENBWGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org