You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Senaka Fernando (JIRA)" <ji...@apache.org> on 2008/02/06 08:09:07 UTC
[jira] Created: (AXIS2C-966) Guththila has no support 4 XML
declarations
Guththila has no support 4 XML declarations
-------------------------------------------
Key: AXIS2C-966
URL: https://issues.apache.org/jira/browse/AXIS2C-966
Project: Axis2-C
Issue Type: Bug
Components: guththila
Affects Versions: 1.3.0
Reporter: Senaka Fernando
Assignee: Senaka Fernando
Fix For: 1.3.0
Guththila has no support 4 XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
Regards,
Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Resolved: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Senaka Fernando resolved AXIS2C-966.
------------------------------------
Resolution: Fixed
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567636#action_12567636 ]
Senaka Fernando commented on AXIS2C-966:
----------------------------------------
Hi Bill,
I fixed the issue on Guththila, it now prints what we request. If we wont give anything, it will print what it has. Also, it utilizes the existing constant, so no worries on new macros etc.
On the new question,
Simply, I think we can use the same encoding for both. However, I didn't quite get what you say in the phrase "absent other information". What do you mean here?
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567642#action_12567642 ]
Senaka Fernando commented on AXIS2C-966:
----------------------------------------
Also, Bill,
I have used this approach to covey messages to from client to transport, when i was working with authentication.
1. If it is uni-directional, and if it is from client -> transport, the popular choice is to set an option. I think we have many examples in options.c
2. If it is uni-directional, and if it is from transport -> client, set it to the message context and use service client to extract the info from the message context and expose it through another method.
3. If it is bi-directional, you can use the above two methods in combination.
4. There may be situations where setting something in the service client is more efficient than setting an option and passing it to the service client. This comes in handy especially when the conversation involves maintaining state.
I hope this may help you with informing Upper Layers about the character encoding used.
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Reopened: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Senaka Fernando reopened AXIS2C-966:
------------------------------------
Hi Bill,
Yes, I think you have a valid point here. Guththila must also be able to specify the version+encoding passed by a user. I noticed that too. I thought that it wouldn't be much of a problem for the moment. But, I believe you have a point here. However, your argument is valid IF AND ONLY IF Guththila can support other encodings. What I felt was, Guththila was designed to run only with UTF-8 and that's why it is hardcoded. Thoughts?
However, as you suggest I will try to modify the function being called so that it can handle other types.
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Issue Comment Edited: (AXIS2C-966) Guththila has no support
for XML declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567642#action_12567642 ]
senakafdo edited comment on AXIS2C-966 at 2/11/08 6:14 AM:
-----------------------------------------------------------------
Also, Bill,
I have used this approach to covey messages to/from client to transport, when I was working with authentication.
1. If it is uni-directional, and if it is from client -> transport, the popular choice is to set an option. I think we have many examples in options.c
2. If it is uni-directional, and if it is from transport -> client, set it to the message context and use service client to extract the info from the message context and expose it through another method.
3. If it is bi-directional, you can use the above two methods in combination.
4. There may be situations where setting something in the service client is more efficient than setting an option and passing it to the service client. This comes in handy especially when the conversation involves maintaining state.
I hope this may help you with informing Upper Layers about the character encoding used.
Regards,
Senaka
was (Author: senakafdo):
Also, Bill,
I have used this approach to covey messages to from client to transport, when i was working with authentication.
1. If it is uni-directional, and if it is from client -> transport, the popular choice is to set an option. I think we have many examples in options.c
2. If it is uni-directional, and if it is from transport -> client, set it to the message context and use service client to extract the info from the message context and expose it through another method.
3. If it is bi-directional, you can use the above two methods in combination.
4. There may be situations where setting something in the service client is more efficient than setting an option and passing it to the service client. This comes in handy especially when the conversation involves maintaining state.
I hope this may help you with informing Upper Layers about the character encoding used.
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Bill Mitchell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567627#action_12567627 ]
Bill Mitchell commented on AXIS2C-966:
--------------------------------------
Senaka, here's another question, while we are both thinking about this. I noticed in axis2_libcurl that it causes the xml declaration to be built, then it determines the text encoding to be inserted in the http content-type header. And I was wondering why this would not be done in the other order? As the http content-type character encoding may be configurable, it would make sense, absent other information, to identify the same character encoding in the http content-type header and in the xml declaration.
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Resolved: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Senaka Fernando resolved AXIS2C-966.
------------------------------------
Resolution: Fixed
Hi Bill,
I believe that we can resolve this issue, as the present discussion, your new question, does not relate to this.
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567417#action_12567417 ]
Senaka Fernando commented on AXIS2C-966:
----------------------------------------
Fixed Issue. It was that we were passing NULL as the xml_version, that failed a PARAM_CHECK in the guththila wrapper. :D... At least now I believe that some PARAM_CHECKs are really necessary for us to know what we are doing and not.
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Bill Mitchell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567513#action_12567513 ]
Bill Mitchell commented on AXIS2C-966:
--------------------------------------
Senaka, you fixed all the issues I observed at the upper layers. And I have verified that the request message sent via libcurl now contains a ?xml declaration.
But the fix works in part by accident. guththila_xml_writer_wrapper_write_start_document_with_version_encoding() now receives a valid encoding and version, so it does not fail the parm checks. But it calls guththila_write_start_document() which accepts no parameters and always generates a ?xml declaration specifying version 1.0 and UTF-8, hardcoded in the string GUTHTHILA_WRITER_SD_DECLARATION. guththila_write_start_document() has no access to the values passed into guththila_xml_writer_wrapper. So if anyone configured the document to specify a different char set encoding, the ?xml declaration would indicate UTF-8 instead of the specified encoding.
I'm not sure if this should be tracked as a separate issue, or as part of the same issue. My first inclination would be to reopen it, except that what is there is sufficient, I think, to match the claimed capabilities of 1.3. I don't know that there is yet any functionality in the upper levels to let the client or server app get to the om_output structure and set the char-set encoding.
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Updated: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Senaka Fernando updated AXIS2C-966:
-----------------------------------
Description:
Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
Regards,
Senaka
was:
Guththila has no support 4 XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
Regards,
Senaka
Summary: Guththila has no support for XML declarations (was: Guththila has no support 4 XML declarations)
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-966) Guththila has no support for XML
declarations
Posted by "Bill Mitchell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567620#action_12567620 ]
Bill Mitchell commented on AXIS2C-966:
--------------------------------------
Actually, Senaka, I think that guththila could handle other single byte encodings today. Obviously multibyte encodings like UTF-16 are another story. But on the single byte latin encodings, 8859-x, I think all the special characters that are significant to XML are at the same code points. When I was looking at verifying this on incoming messages, the stumbling block I found was that the character encoding from the ?xml declaration is passed up only one layer and then lost, the client app doesn't seem to have a way to learn which encoding was used. Except for that, I think guththila and the rest of Axis2c is neutral for all single byte encodings.
Regards,
Bill
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Issue Comment Edited: (AXIS2C-966) Guththila has no support
for XML declarations
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567526#action_12567526 ]
senakafdo edited comment on AXIS2C-966 at 2/10/08 10:20 PM:
------------------------------------------------------------------
Hi Bill,
Yes, I think you are correct. You can pass the version and encoding from Upper Layers. And, Guththila must be able to specify the version+encoding passed by a Upper Layers. I noticed that too. I thought that it wouldn't be much of a problem for the moment. But, I believe you have a point here. However, your argument is valid IF AND ONLY IF Guththila can support other encodings. What I felt was, Guththila was designed to run only with UTF-8 and that's why it is hardcoded. Thoughts?
However, as you suggest I will try to modify the function being called so that it can handle other types. We can convert that constant into a macro, or if it is sort of problematic, re-define another macro.
Regards,
Senaka
was (Author: senakafdo):
Hi Bill,
Yes, I think you have a valid point here. Guththila must also be able to specify the version+encoding passed by a user. I noticed that too. I thought that it wouldn't be much of a problem for the moment. But, I believe you have a point here. However, your argument is valid IF AND ONLY IF Guththila can support other encodings. What I felt was, Guththila was designed to run only with UTF-8 and that's why it is hardcoded. Thoughts?
However, as you suggest I will try to modify the function being called so that it can handle other types.
Regards,
Senaka
> Guththila has no support for XML declarations
> ---------------------------------------------
>
> Key: AXIS2C-966
> URL: https://issues.apache.org/jira/browse/AXIS2C-966
> Project: Axis2-C
> Issue Type: Bug
> Components: guththila
> Affects Versions: 1.3.0
> Reporter: Senaka Fernando
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
>
> Guththila has no support for XML declarations. Bill, pointed this out in an e-mail sent to the AXIS2C-dev list. It is required that Guththila understands the XML declaration elements and simply do not treat it as an error.
> Regards,
> Senaka
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org