[jira] [Commented] (FOP-2469) [PATCH] auto table layout

["Andreas L. Delmelle (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547140#comment-14547140 ] 

Andreas L. Delmelle commented on FOP-2469:
------------------------------------------


Had a closer look at the patch. Looks promising, but I already have one preliminary question:

What exactly is the rationale for adding the related methods to AbstractBaseLayoutManager and method signatures to the LayoutManager interface? Those serve as the base class and interface for ALL layout managers, not only those related to tables.
Somehow, something does not feel quite right about that. It seems to 'pollute' the general LM interfaces with methods that only apply in a very specific context (?) It almost has a similar feel as adding signatures for map-related methods to the general Collection interface or AbstractCollection base class in the JCF...

At this point, I am not insisting that the approach is wrong. Could be that I am missing something obvious... It's been known to happen. :-)

Can you clarify?

> [PATCH] auto table layout
> -------------------------
>
>                 Key: FOP-2469
>                 URL: https://issues.apache.org/jira/browse/FOP-2469
>             Project: Fop
>          Issue Type: Bug
>          Components: layout/unqualified
>    Affects Versions: trunk
>         Environment: Windows 7, JDK 7
>            Reporter: Gregor Berg
>             Fix For: trunk
>
>         Attachments: 2015-05-13-auto-table-layout.patch, FOP2469-auto-table-layout.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can not only handle linebreaks and pagebreaks, but it also copes with auto tables in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)